react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Fix ReactJSXElementValidator tests

Open eps1lon opened this issue 9 months ago • 3 comments

Summary

Noticed in https://github.com/facebook/react/pull/29088 that some of these test assertions rely on the fact that Component does not handle children. This is likely a bug with the test since you wouldn't write components like this. Static type-checking would reject <Component>{children}</Component> when Component doesn't implement handling of children.

How did you test this change?

  • yarn test --watch packages/react/src/__tests__/ReactJSXElementValidator-test.js

eps1lon avatar May 21 '24 10:05 eps1lon