facebook
Create Fabric-specific version of ReactNativeAttributesPayload
Summary
This PR introduces Fabric-only version of ReactNativeAttributesPayload. It is a copy-paste of ReactNativeAttributesPayload.js, and is called ReactNativeAttributesPayloadFabric.js.
The idea behind this change is that certain optimizations in prop diffing may actually be a regression on the old architecture. For example, removing custom diffing may result in larger updateProps payloads. Which is, I guess, fine with JSI, but might be a problem with the bridge.
How did you test this change?
There should be no runtime effect of this change.
Comparing: b498834eab8d6cef88305f56acb03540d1f2659b...ad43eeceb4a4b377f641e49d18c18d1f24a9f92f
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 494.06 kB | 494.06 kB | = | 88.22 kB | 88.21 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 498.86 kB | 498.86 kB | = | 88.93 kB | 88.92 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 591.22 kB | 591.22 kB | = | 103.96 kB | 103.96 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 567.44 kB | 567.44 kB | = | 100.36 kB | 100.36 kB |
| test_utils/ReactAllWarnings.js | Deleted | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| react-native/implementations/ReactNativeRenderer-profiling.fb.js | = | 400.74 kB | 399.47 kB | = | 69.73 kB | 69.57 kB |
| react-native/implementations/ReactNativeRenderer-prod.fb.js | = | 373.51 kB | 372.23 kB | = | 65.42 kB | 65.28 kB |
| test_utils/ReactAllWarnings.js | Deleted | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB |
Generated by :no_entry_sign: dangerJS against ad43eeceb4a4b377f641e49d18c18d1f24a9f92f
