react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Fix gap between footer logo and links

Open dipanshurdev opened this issue 11 months ago • 3 comments

At the react.dev/learn & react.dev/community or any route add a gap between footer's logo and links

screenshot

Screenshot 2024-03-12 124202

dipanshurdev avatar Mar 12 '24 07:03 dipanshurdev

Is that site on GitHub?

rhen99 avatar Mar 12 '24 09:03 rhen99

issue : #28542 Can you assign this to me? Can you help me , I know what is the problem and I can resolve but I don't know how to start?Should I clone the file first?

sahiladit avatar Mar 12 '24 15:03 sahiladit

Hey @amanr-dev, I was checking and i saw everything alright. I checked on a few resolutions and all seems to be fine. Could you provide more information to replicate that UI error ?

Luguito avatar Mar 13 '24 00:03 Luguito

Hey @amanr-dev, I checked both react.dev/learn & react.dev/community on all resolutions and everything seems to be fine.

kodaliakhil avatar Mar 13 '24 04:03 kodaliakhil

I'm proficient with this,Can you assign it to me

Harshit1723 avatar Mar 19 '24 14:03 Harshit1723

@Harshit1723 the resolution was that this issue isn't reproducible on other devices. Can you reproduce this issue on your device? If so, please open a new issue with instructions for how to repro.

Thanks!

pwbriggs avatar Mar 20 '24 01:03 pwbriggs

Could you assign this issue to me? I can reproduce it on my device:

Screenshot 2024-03-20 at 09 49 17

I am using a Macbook.

Steps to reproduce:

  • Open the website link
  • Scroll to the footer and you will see there is no space between the loge and the (link)[https://opensource.fb.com/]

Suggestion:

The space between the logo and the link should look like this:

image

Instead of this:

image

RitaDee avatar Mar 20 '24 09:03 RitaDee

@RitaDee, assigned to you

dipanshurdev avatar Mar 20 '24 11:03 dipanshurdev

Thank you, @amanr-dev for assigning this issue to me.

RitaDee avatar Mar 20 '24 11:03 RitaDee

@RitaDee I think you misunderstood the issue. The Meta Open Source logo is supposed to look like that (as seen on https://opensource.fb.com). I think the issue @amanr-dev was referring to was this one:

s

Thanks anyway though! ❤️

pwbriggs avatar Mar 20 '24 13:03 pwbriggs

It seems fine ,which system are you using?i'm not getting this issue?

sahiladit avatar Mar 20 '24 15:03 sahiladit

one

Yes , you are right

dipanshurdev avatar Mar 20 '24 15:03 dipanshurdev

It seems fine ,which system are you using?i'm not getting this issue?

My device's screen size is 1519 × 742

dipanshurdev avatar Mar 20 '24 15:03 dipanshurdev

I think you should close this issue.

sahiladit avatar Mar 20 '24 15:03 sahiladit

Screenshot 2024-03-20 at 9 16 35 PM I checked this on my system but it is correctly aligned.

sahiladit avatar Mar 20 '24 15:03 sahiladit

Thank you, @amanr-dev for assigning this issue to me.

Hi @RitaDee, I think I should close this issue a second time. The reason is that the code for the website is not available in the Repository.

dipanshurdev avatar Mar 21 '24 15:03 dipanshurdev