react icon indicating copy to clipboard operation
react copied to clipboard
Published 2 months ago • verified publisher icon facebook

Update README.md. Fixed typo in scripts/error-codes/README.md

Open Tianyou3 opened this issue 1 year ago • 3 comments

Summary

How did you test this change?

Tianyou3 avatar Mar 10 '24 12:03 Tianyou3

Hi @Tianyou3!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 10 '24 12:03 facebook-github-bot

CLA signed

Tianyou3 avatar Mar 10 '24 12:03 Tianyou3

Comparing: 706d95f486fbdec35b771ea4aaf3e78feb907249...b3a25d8e41d0e5613e897fd442146ef9821f3723

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.20 kB 55.20 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.64 kB = 55.53 kB 55.53 kB
facebook-www/ReactDOM-prod.classic.js = 594.34 kB 594.34 kB = 104.96 kB 104.96 kB
facebook-www/ReactDOM-prod.modern.js = 577.60 kB 577.60 kB = 102.02 kB 102.02 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against b3a25d8e41d0e5613e897fd442146ef9821f3723

react-sizebot avatar Mar 10 '24 12:03 react-sizebot

Thanks, but we don't usually accept PRs that fix minor typos in comments because of the noise.

rickhanlonii avatar Mar 24 '24 15:03 rickhanlonii