react icon indicating copy to clipboard operation
react copied to clipboard
Published 2 weeks ago • verified publisher icon facebook

Remove invokeGuardedCallback and replay trick

Open sebmarkbage opened this issue 1 year ago • 2 comments

We broke the ability to "break on uncaught exceptions" by adding a try/catch higher up in the scheduling. We're giving up on fixing that so we can remove the replay trick inside an event handler.

The issue with that approach is that we end up double logging a lot of errors in DEV since they get reported to the page.

It's also a lot of complexity around this feature.

sebmarkbage avatar Mar 07 '24 06:03 sebmarkbage

Comparing: 7d6f1e3c13686272c1d76813992d4e782fcb84e6...8ed9d7ce7bd4b803f2ec5c44e283120163ee8743

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 176.71 kB = 55.20 kB 54.89 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.25 kB = 55.53 kB 55.25 kB
facebook-www/ReactDOM-prod.classic.js = 593.92 kB 592.84 kB = 104.85 kB 104.15 kB
facebook-www/ReactDOM-prod.modern.js = 577.18 kB 576.10 kB = 101.91 kB 101.21 kB
oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js = 12.52 kB 12.03 kB = 4.87 kB 4.70 kB
oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js = 12.52 kB 12.03 kB = 4.87 kB 4.70 kB
oss-stable/react-dom/umd/react-dom-test-utils.production.min.js = 12.52 kB 12.03 kB = 4.87 kB 4.70 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js = 12.43 kB 11.94 kB = 4.82 kB 4.66 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js = 12.43 kB 11.94 kB = 4.82 kB 4.66 kB
oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js = 12.43 kB 11.94 kB = 4.82 kB 4.66 kB
facebook-www/ReactTestUtils-dev.classic.js = 54.14 kB 51.14 kB = 13.80 kB 13.07 kB
facebook-www/ReactTestUtils-dev.modern.js = 54.14 kB 51.14 kB = 13.80 kB 13.07 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.production.js = 45.18 kB 42.64 kB = 12.81 kB 12.11 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js = 45.18 kB 42.64 kB = 12.81 kB 12.11 kB
oss-stable/react-dom/cjs/react-dom-test-utils.production.js = 45.18 kB 42.64 kB = 12.81 kB 12.11 kB
oss-experimental/react-dom/umd/react-dom-test-utils.development.js = 58.17 kB 47.41 kB = 16.21 kB 13.10 kB
oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js = 58.17 kB 47.41 kB = 16.21 kB 13.10 kB
oss-stable/react-dom/umd/react-dom-test-utils.development.js = 58.17 kB 47.41 kB = 16.21 kB 13.10 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.development.js = 55.01 kB 44.64 kB = 15.92 kB 12.87 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js = 55.01 kB 44.64 kB = 15.92 kB 12.87 kB
oss-stable/react-dom/cjs/react-dom-test-utils.development.js = 55.01 kB 44.64 kB = 15.92 kB 12.87 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/umd/react-dom.profiling.min.js = 186.40 kB 186.01 kB = 58.15 kB 57.72 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js = 185.85 kB 185.46 kB = 57.85 kB 57.46 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js = 185.77 kB 185.39 kB = 57.82 kB 57.44 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js = 187.11 kB 186.72 kB = 57.89 kB 57.57 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js = 186.57 kB 186.18 kB = 57.55 kB 57.24 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js = 186.49 kB 186.11 kB = 57.52 kB 57.21 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js = 183.69 kB 183.30 kB = 57.79 kB 57.52 kB
oss-experimental/react-dom/umd/react-dom.production.min.js = 177.37 kB 176.98 kB = 55.77 kB 55.43 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.25 kB = 55.53 kB 55.25 kB
oss-stable/react-dom/umd/react-dom.production.min.js = 176.82 kB 176.43 kB = 55.47 kB 55.10 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js = 176.74 kB 176.36 kB = 55.44 kB 55.07 kB
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 176.71 kB = 55.20 kB 54.89 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js = 177.02 kB 176.64 kB = 55.17 kB 54.87 kB
oss-experimental/react-dom/cjs/react-dom.profiling.js = 998.98 kB 996.42 kB = 222.71 kB 221.90 kB
oss-stable/react-dom/cjs/react-dom.profiling.js = 996.42 kB 993.85 kB = 221.61 kB 220.81 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.js = 996.39 kB 993.83 kB = 221.59 kB 220.78 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 974.97 kB 972.40 kB = 219.60 kB 218.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 957.05 kB 954.48 kB = 215.12 kB 214.31 kB
oss-stable/react-dom/cjs/react-dom.production.js = 954.48 kB 951.91 kB = 214.06 kB 213.25 kB
oss-stable-semver/react-dom/cjs/react-dom.production.js = 954.45 kB 951.89 kB = 214.03 kB 213.22 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 401.56 kB 400.45 kB = 70.29 kB 69.79 kB
react-native/implementations/ReactFabric-profiling.fb.js = 394.08 kB 392.95 kB = 69.01 kB 68.47 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 374.20 kB 373.09 kB = 66.01 kB 65.46 kB
react-native/implementations/ReactFabric-prod.fb.js = 366.79 kB 365.65 kB = 64.73 kB 64.20 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 355.28 kB 354.17 kB = 62.30 kB 61.77 kB
react-native/implementations/ReactFabric-profiling.js = 345.55 kB 344.41 kB = 60.54 kB 60.08 kB
react-native/implementations/ReactNativeRenderer-prod.js = 335.88 kB 334.77 kB = 59.08 kB 58.58 kB
react-native/implementations/ReactFabric-prod.js = 326.87 kB 325.74 kB = 57.47 kB 56.99 kB
facebook-www/ReactTestRenderer-dev.classic.js = 945.36 kB 941.63 kB = 188.33 kB 187.15 kB
facebook-www/ReactTestRenderer-dev.modern.js = 945.36 kB 941.62 kB = 188.33 kB 187.14 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,691.75 kB 1,681.72 kB = 336.12 kB 333.43 kB
facebook-www/ReactDOM-dev.classic.js = 1,670.23 kB 1,660.20 kB = 331.57 kB 328.89 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,660.67 kB 1,650.64 kB = 330.62 kB 327.94 kB
facebook-www/ReactDOM-dev.modern.js = 1,639.21 kB 1,629.17 kB = 326.06 kB 323.41 kB
facebook-www/ReactART-dev.classic.js = 1,065.88 kB 1,056.80 kB = 209.46 kB 206.92 kB
facebook-www/ReactART-dev.modern.js = 1,053.67 kB 1,044.60 kB = 207.04 kB 204.49 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,357.96 kB 1,341.57 kB = 300.46 kB 295.51 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,404.68 kB 1,387.65 kB = 299.19 kB 294.25 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,403.26 kB 1,386.23 kB = 298.75 kB 293.85 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,403.23 kB 1,386.20 kB = 298.73 kB 293.82 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,340.17 kB 1,323.77 kB = 296.19 kB 291.25 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,338.91 kB 1,322.51 kB = 295.78 kB 290.87 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,338.88 kB 1,322.49 kB = 295.75 kB 290.83 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 933.09 kB 920.77 kB = 186.44 kB 182.85 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 863.83 kB 852.29 kB = 182.53 kB 178.93 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js = 863.81 kB 852.27 kB = 182.50 kB 178.90 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 861.98 kB 850.44 kB = 182.03 kB 178.43 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 824.94 kB 813.81 kB = 180.57 kB 176.99 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 824.91 kB 813.79 kB = 180.54 kB 176.96 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 823.18 kB 812.05 kB = 180.09 kB 176.50 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 954.04 kB 938.61 kB = 204.52 kB 199.78 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 945.22 kB 929.79 kB = 202.91 kB 198.15 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 945.19 kB 929.77 kB = 202.88 kB 198.13 kB
oss-experimental/react-art/umd/react-art.development.js = 967.58 kB 951.42 kB = 204.22 kB 199.50 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 1,104.37 kB 1,085.89 kB = 221.56 kB 216.60 kB
oss-stable/react-art/umd/react-art.development.js = 961.01 kB 944.84 kB = 203.54 kB 198.83 kB
oss-stable-semver/react-art/umd/react-art.development.js = 960.98 kB 944.81 kB = 203.51 kB 198.81 kB
react-native/implementations/ReactFabric-dev.fb.js = 1,089.80 kB 1,071.32 kB = 217.71 kB 212.73 kB
react-native/implementations/ReactNativeRenderer-dev.js = 1,018.40 kB 999.92 kB = 205.14 kB 200.16 kB
oss-experimental/react-art/cjs/react-art.development.js = 850.71 kB 835.14 kB = 184.96 kB 180.14 kB
oss-stable/react-art/cjs/react-art.development.js = 844.49 kB 828.92 kB = 184.34 kB 179.51 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 844.46 kB 828.90 kB = 184.32 kB 179.48 kB
react-native/implementations/ReactFabric-dev.js = 1,002.12 kB 983.64 kB = 201.05 kB 196.06 kB
oss-experimental/react-dom/umd/react-dom-test-utils.production.min.js = 12.52 kB 12.03 kB = 4.87 kB 4.70 kB
oss-stable-semver/react-dom/umd/react-dom-test-utils.production.min.js = 12.52 kB 12.03 kB = 4.87 kB 4.70 kB
oss-stable/react-dom/umd/react-dom-test-utils.production.min.js = 12.52 kB 12.03 kB = 4.87 kB 4.70 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.production.min.js = 12.43 kB 11.94 kB = 4.82 kB 4.66 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.min.js = 12.43 kB 11.94 kB = 4.82 kB 4.66 kB
oss-stable/react-dom/cjs/react-dom-test-utils.production.min.js = 12.43 kB 11.94 kB = 4.82 kB 4.66 kB
facebook-www/ReactTestUtils-dev.classic.js = 54.14 kB 51.14 kB = 13.80 kB 13.07 kB
facebook-www/ReactTestUtils-dev.modern.js = 54.14 kB 51.14 kB = 13.80 kB 13.07 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.production.js = 45.18 kB 42.64 kB = 12.81 kB 12.11 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.production.js = 45.18 kB 42.64 kB = 12.81 kB 12.11 kB
oss-stable/react-dom/cjs/react-dom-test-utils.production.js = 45.18 kB 42.64 kB = 12.81 kB 12.11 kB
oss-experimental/react-dom/umd/react-dom-test-utils.development.js = 58.17 kB 47.41 kB = 16.21 kB 13.10 kB
oss-stable-semver/react-dom/umd/react-dom-test-utils.development.js = 58.17 kB 47.41 kB = 16.21 kB 13.10 kB
oss-stable/react-dom/umd/react-dom-test-utils.development.js = 58.17 kB 47.41 kB = 16.21 kB 13.10 kB
oss-experimental/react-dom/cjs/react-dom-test-utils.development.js = 55.01 kB 44.64 kB = 15.92 kB 12.87 kB
oss-stable-semver/react-dom/cjs/react-dom-test-utils.development.js = 55.01 kB 44.64 kB = 15.92 kB 12.87 kB
oss-stable/react-dom/cjs/react-dom-test-utils.development.js = 55.01 kB 44.64 kB = 15.92 kB 12.87 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against 8ed9d7ce7bd4b803f2ec5c44e283120163ee8743

react-sizebot avatar Mar 07 '24 06:03 react-sizebot

It's not quite that easy it turns out. Added a bunch of TODOs.

sebmarkbage avatar Mar 10 '24 00:03 sebmarkbage

There's no way to silence the logs when an error boundary catches it now but I have a follow up to change a few other things and introduce a possible way to silence it, but it can't be onerror that does it which is a breaking change.

sebmarkbage avatar Mar 11 '24 23:03 sebmarkbage