react icon indicating copy to clipboard operation
react copied to clipboard

Add dynamic disablePropFilteringInViewConfigs flag for native-fb

Open dmytrorykun opened this issue 2 years ago • 2 comments

Adds the disablePropFilteringInViewConfigs flag to set up and experiment to see the performance implications of not filtering out invalid props in the diffProperties function.

If disablePropFilteringInViewConfigs is true, we skip prop diffing and prop filtering, and send all props to native.

dmytrorykun avatar Feb 22 '24 18:02 dmytrorykun

Comparing: aa4eae6b99a6081afabf180d02fa0a8b0cb1b3ab...c5c671d54af4c6f05e69b16fa7f935d7e930ac7c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.19 kB 177.19 kB = 55.23 kB 55.23 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.72 kB 177.72 kB = 55.55 kB 55.55 kB
facebook-www/ReactDOM-prod.classic.js = 594.67 kB 594.67 kB = 105.04 kB 105.04 kB
facebook-www/ReactDOM-prod.modern.js = 577.93 kB 577.93 kB = 102.10 kB 102.10 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against c5c671d54af4c6f05e69b16fa7f935d7e930ac7c

react-sizebot avatar Feb 22 '24 18:02 react-sizebot

I don't see any references to the feature flag. Where should that be checked?

kassens avatar Feb 22 '24 18:02 kassens

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jun 03 '24 15:06 github-actions[bot]