Fix for script yarn build-for-devtools-dev failing due to argument type
The script yarn build-for-devtools-dev fails due to the function parseRequestedNames in the build file is using the split on the names arguments and in this case since the arguments passed is of type array which doesn't support the prototype split.
Fix: Added the fallback method in case the args passed to function is of type array then don't split the input.
Yarn build-for-devtools-dev after these added changes resolve the issue.
Comparing: 5ab6bbb4b058e22658fc6d4734db5acfbf393345...d6c1702d991fef19ddce18bde85a05c39ce11421
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.min.js | = | 175.90 kB | 175.90 kB | = | 54.75 kB | 54.75 kB |
| oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 177.97 kB | 177.97 kB | = | 55.39 kB | 55.39 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 569.81 kB | 569.81 kB | = | 100.29 kB | 100.29 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 553.67 kB | 553.67 kB | = | 97.38 kB | 97.38 kB |
| test_utils/ReactAllWarnings.js | Deleted | 67.17 kB | 0.00 kB | Deleted | 16.35 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| test_utils/ReactAllWarnings.js | Deleted | 67.17 kB | 0.00 kB | Deleted | 16.35 kB | 0.00 kB |
Generated by :no_entry_sign: dangerJS against d6c1702d991fef19ddce18bde85a05c39ce11421
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!