react icon indicating copy to clipboard operation
react copied to clipboard

convert circleci workflow devtools_regression_tests to github actions

Open robandpdx opened this issue 1 year ago • 1 comments

Summary

This pull request converts the CircleCI workflows to GitHub actions workflows. Github Actions Importer was used to convert the workflows initially, then I edited them manually to correct errors in translation.

Issues

  1. facebook/react/devtools_regression_tests
    The scripts that this workflow calls need to be modified.

How did you test this change?

I tested these changes in a forked repo. You can view the logs of this workflow in my fork.

https://fburl.com/workplace/f6mz6tmw

robandpdx avatar Dec 06 '23 17:12 robandpdx

Comparing: 0066e0b68d90cc71a137f26b7c5bf6af73398fc2...e66bfb8ef73d0fd06a70df1d574732b5bf054aa6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.19 kB 55.19 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.64 kB = 55.52 kB 55.52 kB
facebook-www/ReactDOM-prod.classic.js = 594.36 kB 594.36 kB = 104.96 kB 104.96 kB
facebook-www/ReactDOM-prod.modern.js = 577.62 kB 577.62 kB = 102.01 kB 102.01 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against e66bfb8ef73d0fd06a70df1d574732b5bf054aa6

react-sizebot avatar Dec 06 '23 17:12 react-sizebot

Heads up I reverted this because it broke main. @robandpdx can you re-submit the PR?

rickhanlonii avatar Apr 18 '24 14:04 rickhanlonii

@rickhanlonii https://github.com/facebook/react/pull/28875

robandpdx avatar Apr 19 '24 03:04 robandpdx