react
react copied to clipboard
facebook
[react] Cleanup enableCustomElementPropertySupport flag
We've rolled out this flag internally on WWW. This PR removed flag enableCustomElementPropertySupport
Test plan:
-- yarn test
Comparing: a73c3450e1b528fa6cb3e94fa4d4359c7a4b61f1...670c7fab7dbb42dbca995e36b3b581e020d23e34
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.min.js | +0.25% | 176.69 kB | 177.13 kB | +0.21% | 54.93 kB | 55.05 kB |
| oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 173.09 kB | 173.09 kB | = | 53.94 kB | 53.94 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 592.87 kB | 592.87 kB | = | 104.00 kB | 104.00 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 574.56 kB | 574.56 kB | = | 101.02 kB | 101.02 kB |
| test_utils/ReactAllWarnings.js | Deleted | 65.05 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable-semver/react-dom/umd/react-dom.production.min.js | +0.25% | 176.35 kB | 176.79 kB | +0.24% | 55.14 kB | 55.28 kB |
| oss-stable/react-dom/umd/react-dom.production.min.js | +0.25% | 176.43 kB | 176.87 kB | +0.25% | 55.17 kB | 55.31 kB |
| oss-stable-semver/react-dom/cjs/react-dom.production.min.js | +0.25% | 176.61 kB | 177.05 kB | +0.22% | 54.90 kB | 55.02 kB |
| oss-stable/react-dom/cjs/react-dom.production.min.js | +0.25% | 176.69 kB | 177.13 kB | +0.21% | 54.93 kB | 55.05 kB |
| oss-stable-semver/react-dom/umd/react-dom.profiling.min.js | +0.24% | 185.38 kB | 185.82 kB | +0.20% | 57.53 kB | 57.65 kB |
| oss-stable/react-dom/umd/react-dom.profiling.min.js | +0.24% | 185.46 kB | 185.90 kB | +0.20% | 57.56 kB | 57.67 kB |
| oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js | +0.24% | 186.08 kB | 186.52 kB | +0.21% | 57.26 kB | 57.38 kB |
| oss-stable/react-dom/cjs/react-dom.profiling.min.js | +0.24% | 186.16 kB | 186.60 kB | +0.21% | 57.29 kB | 57.41 kB |
| test_utils/ReactAllWarnings.js | Deleted | 65.05 kB | 0.00 kB | Deleted | 16.26 kB | 0.00 kB |
Generated by :no_entry_sign: dangerJS against 670c7fab7dbb42dbca995e36b3b581e020d23e34
There's a known issue with this flag here: https://github.com/facebook/react/issues/27286
just pinging this thread to see if there are any barriers to getting this merged? This PR is a clear signal of web component support in react and a lot of web components advocates are eagerly awaiting :)
@michaelwarren1106 our plan is to include this in our next stable release which is being put together now. It will be merged closer to when we are ready to publish
@gnoff While your comment above gives me some hope, I still find myself wondering if I actually understand what to expect in the next stable release. Is there a roadmap published with the contents of the next stable release somewhere? I could not find anything myself; I have some older information about what you're working on but I don't consider everything I read to be a commitment or a comprehensive list (and support for custom element support is never mentioned).
To be honest monitoring GitHub threads (like this one) for the last several years has been frustrating and confusing. Will the React team please state plainly what to expect regarding support for custom elements in a blog post here: react.dev/blog?
As evidence that there is tremendous appetite for this content I will mention this relates to the #2 most discussed issue and the most hearted issue (it's the same) in the list of public React issues (issue locked since Oct 2023).
What I think I can expect is that the next major release will show all 32 basic & advanced tests on custom-elements-everywhere.com to be passing in an upcoming stable React release. Today this is true for React^0.0.0-experimental-3ddbedd05-20220719 which I am really happy to see. However without an announcement in an official public channel I must still hold my applause (for now).
Sorry for the rant; I do appreciate the React team's efforts! Also 👋🏻 @poteto — it's good to see a familiar face working on this :)
@klebba we're finalizing the release and then we'll be able to share what's in it. For custom elements, since this PR turns the flag on from experimental, they will ship with the PR. The main reason we're not merging this yet is because it contains breaking changes that we're not ready to land until other things in the release are ready.
Hi @rickhanlonii — thanks for your reply. I'll reiterate what I'm asking, I don't intend to be controversial and only want to know about this subject:
this PR turns the
enableCustomElementPropertySupportflag on from experimental
What exactly does this flag do? What does it not do? I still hope the React team will soon state plainly what to expect regarding support for custom elements in a blog post here: react.dev/blog.
To be clear, I'm not asking:
- For anything specific to be merged
- For any schedule commitments to be made
I'm recommending:
- Official communication about planned future support for custom elements in React
- Explicit enumeration of what's in / what's out / unknown
So that I can have:
- Ability to un-watch #11347
- Ability to inform expensive forward looking business decisions regarding React
- An official statement I can share with colleagues and executives
- Confidence that I won't be disappointed and stuck again-again (no blame or fault intended, but I was still disappointed and stuck):
My dream would be to read a blog post on react.dev/blog along these lines:
Plan for custom elements support in next stable release
TL;DR — React 19 will now be more compatible with and have direct support for custom elements. Developers can expect that all tests on custom-elements-everywhere.com will pass by default going forward. Release date still to be announced.
Special thanks to @robdodson for championing this cause long ago!
Thanks for your time and effort!
@klebba I posted an update in https://github.com/facebook/react/issues/11347#issuecomment-1899140345, we'll share updates on the blog when we share more about the next release.