facebook
Scheduler: Unref the MessageChannel instance and allow the thread to exit
Summary
Fixes #26608
How did you test this change?
It is still unclear to me how to test this because test requires separate Jest setup.
Comparing: 5426af3d50ff706f3ebeb4764f838e0a3812bf9a...a755b4a03d08da33550005c25180932fa16edc94
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.min.js | = | 164.40 kB | 164.40 kB | = | 51.65 kB | 51.65 kB |
| oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 166.84 kB | 166.84 kB | = | 52.30 kB | 52.30 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 565.32 kB | 565.32 kB | = | 99.49 kB | 99.49 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 549.11 kB | 549.11 kB | = | 96.79 kB | 96.79 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-experimental/scheduler/cjs/scheduler.development.js | +1.15% | 18.04 kB | 18.25 kB | +1.16% | 5.08 kB | 5.14 kB |
| oss-stable-semver/scheduler/cjs/scheduler.development.js | +1.15% | 18.04 kB | 18.25 kB | +1.16% | 5.08 kB | 5.14 kB |
| oss-stable/scheduler/cjs/scheduler.development.js | +1.15% | 18.04 kB | 18.25 kB | +1.16% | 5.08 kB | 5.14 kB |
| facebook-react-native/scheduler/cjs/Scheduler-dev.js | +1.15% | 18.08 kB | 18.28 kB | +1.16% | 5.09 kB | 5.15 kB |
| facebook-www/Scheduler-dev.classic.js | +0.79% | 26.09 kB | 26.30 kB | +0.83% | 6.87 kB | 6.93 kB |
| facebook-www/Scheduler-dev.modern.js | +0.79% | 26.09 kB | 26.30 kB | +0.83% | 6.87 kB | 6.93 kB |
| oss-experimental/scheduler/cjs/scheduler.production.min.js | +0.72% | 4.30 kB | 4.33 kB | +0.50% | 1.80 kB | 1.81 kB |
| oss-stable-semver/scheduler/cjs/scheduler.production.min.js | +0.72% | 4.30 kB | 4.33 kB | +0.50% | 1.80 kB | 1.81 kB |
| oss-stable/scheduler/cjs/scheduler.production.min.js | +0.72% | 4.30 kB | 4.33 kB | +0.50% | 1.80 kB | 1.81 kB |
| facebook-react-native/scheduler/cjs/Scheduler-prod.js | +0.46% | 10.53 kB | 10.58 kB | +0.41% | 2.66 kB | 2.67 kB |
| facebook-react-native/scheduler/cjs/Scheduler-profiling.js | +0.43% | 11.14 kB | 11.19 kB | +0.36% | 2.80 kB | 2.81 kB |
| facebook-www/Scheduler-prod.classic.js | +0.41% | 11.84 kB | 11.89 kB | +0.41% | 2.93 kB | 2.94 kB |
| facebook-www/Scheduler-prod.modern.js | +0.41% | 11.84 kB | 11.89 kB | +0.41% | 2.93 kB | 2.94 kB |
| facebook-www/Scheduler-profiling.classic.js | +0.30% | 16.01 kB | 16.06 kB | +0.32% | 3.72 kB | 3.74 kB |
| facebook-www/Scheduler-profiling.modern.js | +0.30% | 16.01 kB | 16.06 kB | +0.32% | 3.72 kB | 3.74 kB |
| oss-stable-semver/react/umd/react.profiling.min.js | +0.25% | 12.18 kB | 12.21 kB | +0.17% | 4.73 kB | 4.74 kB |
| oss-stable-semver/react/umd/react.production.min.js | +0.25% | 12.18 kB | 12.21 kB | +0.19% | 4.73 kB | 4.74 kB |
| oss-stable/react/umd/react.profiling.min.js | +0.25% | 12.20 kB | 12.23 kB | +0.15% | 4.76 kB | 4.76 kB |
| oss-stable/react/umd/react.production.min.js | +0.25% | 12.20 kB | 12.23 kB | +0.17% | 4.76 kB | 4.76 kB |
| oss-experimental/react/umd/react.profiling.min.js | +0.24% | 12.90 kB | 12.93 kB | +0.14% | 4.97 kB | 4.98 kB |
| oss-experimental/react/umd/react.production.min.js | +0.24% | 12.90 kB | 12.94 kB | +0.16% | 4.97 kB | 4.97 kB |
Generated by :no_entry_sign: dangerJS against a755b4a03d08da33550005c25180932fa16edc94
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bump, yes, I would still like this fix to be applied, we are currently having to apply a quite ugly workaround to get the behaviour we actually want.
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!
I would have bumped this PR when I was prompted but you had the permissions configured to make it impossible for me to do that.
Reopen, please. It's a nice trick to close during summer vacations.