react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Continue Add end-of-frame scheduling for default events

Open tyao1 opened this issue 2 years ago • 1 comments

Summary

Depends on https://github.com/facebook/react/pull/25466 Resubmit https://github.com/facebook/react/pull/25310 rebased and in a different branch.

Continue the work of https://github.com/facebook/react/pull/24594

The major change compared to https://github.com/facebook/react/pull/24594 is that we no longer distinguish UnknownEvent and DefaultEvent, they both use rAF to schedule if enableFrameEndScheduling flag is on.

How did you test this change?

yarn test

tyao1 avatar Oct 12 '22 00:10 tyao1

Comparing: edbfc6399ffa31267a2e884a63194b5ea17514ff...0275531b939d6ee8364c6dee839783606dd136e2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.35 kB 154.37 kB +0.02% 48.99 kB 49.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.50% 156.28 kB 157.05 kB +0.47% 49.61 kB 49.84 kB
facebook-www/ReactDOM-prod.classic.js +0.46% 533.20 kB 535.66 kB +0.53% 94.44 kB 94.94 kB
facebook-www/ReactDOM-prod.modern.js +0.47% 518.30 kB 520.76 kB +0.56% 92.26 kB 92.77 kB
facebook-www/ReactDOMForked-prod.classic.js +0.46% 533.20 kB 535.66 kB +0.53% 94.44 kB 94.94 kB
oss-experimental/jest-react/cjs/jest-react.production.min.js +6.69% 2.42 kB 2.59 kB +3.33% 1.17 kB 1.21 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js +6.69% 2.42 kB 2.59 kB +3.33% 1.17 kB 1.21 kB
oss-stable/jest-react/cjs/jest-react.production.min.js +6.69% 2.42 kB 2.59 kB +3.33% 1.17 kB 1.21 kB
oss-experimental/jest-react/cjs/jest-react.development.js +2.60% 10.65 kB 10.92 kB +1.51% 3.77 kB 3.82 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +2.60% 10.65 kB 10.92 kB +1.51% 3.77 kB 3.82 kB
oss-stable/jest-react/cjs/jest-react.development.js +2.60% 10.65 kB 10.92 kB +1.51% 3.77 kB 3.82 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/jest-react/cjs/jest-react.production.min.js +6.69% 2.42 kB 2.59 kB +3.33% 1.17 kB 1.21 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js +6.69% 2.42 kB 2.59 kB +3.33% 1.17 kB 1.21 kB
oss-stable/jest-react/cjs/jest-react.production.min.js +6.69% 2.42 kB 2.59 kB +3.33% 1.17 kB 1.21 kB
oss-experimental/jest-react/cjs/jest-react.development.js +2.60% 10.65 kB 10.92 kB +1.51% 3.77 kB 3.82 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +2.60% 10.65 kB 10.92 kB +1.51% 3.77 kB 3.82 kB
oss-stable/jest-react/cjs/jest-react.development.js +2.60% 10.65 kB 10.92 kB +1.51% 3.77 kB 3.82 kB
facebook-www/ReactIs-dev.modern.js +1.51% 9.56 kB 9.70 kB +1.11% 2.53 kB 2.56 kB
facebook-www/ReactIs-dev.classic.js +1.51% 9.56 kB 9.70 kB +1.07% 2.54 kB 2.56 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.73% 12.53 kB 12.62 kB +0.86% 3.74 kB 3.77 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.73% 12.53 kB 12.62 kB +0.86% 3.74 kB 3.77 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js +0.73% 12.53 kB 12.62 kB +0.86% 3.74 kB 3.77 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.60 kB 12.69 kB +0.85% 3.76 kB 3.79 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.60 kB 12.69 kB +0.85% 3.76 kB 3.79 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js +0.72% 12.60 kB 12.69 kB +0.85% 3.76 kB 3.79 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.50% 156.28 kB 157.05 kB +0.47% 49.61 kB 49.84 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js +0.48% 160.68 kB 161.45 kB +0.46% 51.43 kB 51.66 kB
facebook-www/ReactDOM-prod.modern.js +0.47% 518.30 kB 520.76 kB +0.56% 92.26 kB 92.77 kB
facebook-www/ReactDOMForked-prod.modern.js +0.47% 518.30 kB 520.76 kB +0.56% 92.26 kB 92.77 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.47% 165.79 kB 166.56 kB +0.44% 52.10 kB 52.33 kB
facebook-www/ReactDOM-prod.classic.js +0.46% 533.20 kB 535.66 kB +0.53% 94.44 kB 94.94 kB
facebook-www/ReactDOMForked-prod.classic.js +0.46% 533.20 kB 535.66 kB +0.53% 94.44 kB 94.94 kB
facebook-www/ReactDOM-profiling.modern.js +0.45% 548.44 kB 550.90 kB +0.50% 96.77 kB 97.25 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.45% 548.44 kB 550.90 kB +0.50% 96.77 kB 97.26 kB
facebook-www/ReactDOM-profiling.classic.js +0.44% 563.43 kB 565.89 kB +0.49% 98.96 kB 99.45 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.44% 563.43 kB 565.89 kB +0.49% 98.96 kB 99.45 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.41% 156.28 kB 156.92 kB +0.44% 50.36 kB 50.58 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.38% 165.11 kB 165.75 kB +0.39% 52.68 kB 52.88 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.72 kB 34.84 kB +0.33% 7.83 kB 7.86 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.72 kB 34.84 kB +0.33% 7.83 kB 7.86 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js +0.34% 34.72 kB 34.84 kB +0.33% 7.83 kB 7.86 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.85 kB 34.97 kB +0.34% 7.85 kB 7.88 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.85 kB 34.97 kB +0.34% 7.85 kB 7.88 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.34% 34.85 kB 34.97 kB +0.34% 7.85 kB 7.88 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.31% 46.52 kB 46.66 kB +0.23% 13.16 kB 13.19 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.31% 46.52 kB 46.66 kB +0.23% 13.16 kB 13.19 kB
facebook-www/ReactTestUtils-dev.modern.js +0.29% 50.30 kB 50.44 kB +0.21% 14.03 kB 14.06 kB
facebook-www/ReactTestUtils-dev.classic.js +0.29% 50.30 kB 50.44 kB +0.20% 14.03 kB 14.05 kB
facebook-www/ReactDOMForked-dev.modern.js +0.26% 1,332.03 kB 1,335.47 kB +0.27% 289.63 kB 290.41 kB
facebook-www/ReactDOM-dev.modern.js +0.26% 1,332.03 kB 1,335.47 kB +0.27% 289.63 kB 290.41 kB
facebook-www/ReactDOMForked-dev.classic.js +0.25% 1,357.03 kB 1,360.46 kB +0.26% 294.24 kB 295.01 kB
facebook-www/ReactDOM-dev.classic.js +0.25% 1,357.03 kB 1,360.46 kB +0.26% 294.25 kB 295.02 kB
oss-experimental/react-dom/cjs/react-dom.development.js +0.23% 1,212.36 kB 1,215.21 kB +0.25% 268.62 kB 269.28 kB
oss-experimental/react-dom/umd/react-dom.development.js +0.23% 1,271.36 kB 1,274.29 kB +0.24% 271.57 kB 272.24 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.23% 1,205.50 kB 1,208.23 kB +0.24% 267.20 kB 267.83 kB
facebook-www/ReactART-dev.modern.js +0.23% 873.45 kB 875.42 kB +0.27% 184.36 kB 184.85 kB
facebook-www/ReactART-dev.classic.js +0.22% 883.91 kB 885.88 kB +0.25% 186.45 kB 186.92 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.22% 107.57 kB 107.81 kB +0.28% 32.74 kB 32.84 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.21% 116.46 kB 116.70 kB +0.26% 34.90 kB 34.99 kB

Generated by :no_entry_sign: dangerJS against 0275531b939d6ee8364c6dee839783606dd136e2

sizebot avatar Oct 12 '22 00:10 sizebot

@acdlite I update this PR to be based on the new approach of batching lanes

tyao1 avatar Dec 02 '22 01:12 tyao1

working on a new version

tyao1 avatar Nov 14 '23 05:11 tyao1