react icon indicating copy to clipboard operation
react copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Attach updatePriority to root

Open tyao1 opened this issue 2 years ago • 1 comments

Summary

Depends on https://github.com/facebook/react/pull/25460

Breaks down https://github.com/facebook/react/pull/25438. In https://github.com/facebook/react/pull/25310 or https://github.com/facebook/react/pull/25438 we are adding a flag to determine what updateType it is on the current sync lane. This PR extracts that, and uses that flag once in the code for now.

How did you test this change?

yarn test

tyao1 avatar Oct 11 '22 23:10 tyao1

Comparing: aa9988e5e669122ed0d76c72f2dea159eef872b4...651346967bcfa819e45b31ea35d562699f50feaa

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.19% 135.47 kB 135.73 kB +0.25% 43.44 kB 43.55 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.18% 148.01 kB 148.28 kB +0.26% 47.33 kB 47.46 kB
facebook-www/ReactDOM-prod.classic.js +0.25% 492.51 kB 493.73 kB +0.24% 87.52 kB 87.73 kB
facebook-www/ReactDOM-prod.modern.js +0.26% 477.80 kB 479.03 kB +0.26% 85.29 kB 85.51 kB
facebook-www/ReactDOMForked-prod.classic.js +0.25% 492.51 kB 493.73 kB +0.24% 87.52 kB 87.73 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.development.js = 1.05 kB 0.96 kB = 0.44 kB 0.43 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-constants.development.js = 1.05 kB 0.96 kB = 0.44 kB 0.43 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.development.js = 1.05 kB 0.96 kB = 0.44 kB 0.43 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.37% 280.80 kB 281.84 kB +0.37% 49.73 kB 49.91 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.35% 296.38 kB 297.42 kB +0.35% 52.09 kB 52.27 kB
facebook-www/ReactART-prod.modern.js +0.34% 319.00 kB 320.08 kB +0.38% 54.46 kB 54.66 kB
facebook-www/ReactART-prod.classic.js +0.32% 329.79 kB 330.83 kB +0.35% 56.26 kB 56.46 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.31% 734.35 kB 736.65 kB +0.25% 157.42 kB 157.81 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.30% 756.39 kB 758.70 kB +0.24% 161.51 kB 161.89 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.30% 756.39 kB 758.70 kB +0.24% 161.51 kB 161.89 kB
react-native/implementations/ReactFabric-prod.js +0.30% 308.86 kB 309.79 kB +0.30% 54.70 kB 54.86 kB
react-native/implementations/ReactFabric-prod.fb.js +0.29% 317.64 kB 318.57 kB +0.28% 56.37 kB 56.53 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.29% 315.64 kB 316.55 kB +0.31% 55.77 kB 55.94 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js +0.29% 96.80 kB 97.08 kB +0.34% 29.74 kB 29.84 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.29% 96.83 kB 97.10 kB +0.35% 29.76 kB 29.87 kB
react-native/implementations/ReactFabric-dev.js +0.28% 812.53 kB 814.84 kB +0.22% 176.20 kB 176.60 kB
facebook-www/ReactDOMTesting-prod.modern.js +0.28% 438.13 kB 439.37 kB +0.26% 80.80 kB 81.01 kB
react-native/implementations/ReactFabric-profiling.js +0.28% 327.95 kB 328.87 kB +0.26% 57.84 kB 58.00 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.28% 324.42 kB 325.33 kB +0.29% 57.42 kB 57.58 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.27% 104.29 kB 104.57 kB +0.38% 31.83 kB 31.95 kB
react-native/implementations/ReactFabric-dev.fb.js +0.27% 850.74 kB 853.04 kB +0.22% 182.94 kB 183.34 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.27% 334.82 kB 335.72 kB +0.29% 58.89 kB 59.06 kB
facebook-www/ReactART-dev.modern.js +0.27% 853.86 kB 856.16 kB +0.21% 179.85 kB 180.24 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.27% 344.30 kB 345.22 kB +0.28% 60.49 kB 60.66 kB
facebook-www/ReactDOMTesting-prod.classic.js +0.27% 453.96 kB 455.18 kB +0.24% 83.39 kB 83.59 kB
facebook-www/ReactART-dev.classic.js +0.27% 864.18 kB 866.48 kB +0.21% 181.93 kB 182.31 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js +0.26% 105.63 kB 105.90 kB +0.32% 31.95 kB 32.05 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.26% 105.65 kB 105.93 kB +0.33% 31.97 kB 32.08 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.26% 822.05 kB 824.20 kB +0.22% 178.76 kB 179.16 kB
facebook-www/ReactDOM-profiling.modern.js +0.26% 507.61 kB 508.93 kB +0.24% 89.80 kB 90.01 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.26% 507.61 kB 508.93 kB +0.24% 89.80 kB 90.01 kB
facebook-www/ReactDOM-prod.modern.js +0.26% 477.80 kB 479.03 kB +0.26% 85.29 kB 85.51 kB
facebook-www/ReactDOMForked-prod.modern.js +0.26% 477.80 kB 479.03 kB +0.26% 85.29 kB 85.51 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.26% 351.15 kB 352.06 kB +0.30% 61.52 kB 61.70 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.25% 786.27 kB 788.25 kB +0.19% 167.26 kB 167.58 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.25% 786.30 kB 788.28 kB +0.19% 167.28 kB 167.60 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.25% 113.14 kB 113.42 kB +0.36% 33.98 kB 34.10 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js +0.25% 860.24 kB 862.39 kB +0.20% 185.56 kB 185.93 kB
facebook-www/ReactDOMTesting-dev.modern.js +0.25% 1,090.52 kB 1,093.23 kB +0.18% 243.34 kB 243.78 kB
facebook-www/ReactDOM-profiling.classic.js +0.25% 522.39 kB 523.69 kB +0.21% 92.13 kB 92.32 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.25% 522.39 kB 523.69 kB +0.21% 92.13 kB 92.32 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.25% 830.70 kB 832.77 kB +0.20% 175.89 kB 176.24 kB
facebook-www/ReactDOM-prod.classic.js +0.25% 492.51 kB 493.73 kB +0.24% 87.52 kB 87.73 kB
facebook-www/ReactDOMForked-prod.classic.js +0.25% 492.51 kB 493.73 kB +0.24% 87.52 kB 87.73 kB
facebook-www/ReactDOMTesting-dev.classic.js +0.24% 1,119.38 kB 1,122.10 kB +0.18% 249.06 kB 249.51 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.24% 720.36 kB 722.10 kB +0.19% 155.93 kB 156.22 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js +0.24% 85.29 kB 85.49 kB +0.32% 26.47 kB 26.55 kB
oss-stable/react-art/cjs/react-art.production.min.js +0.24% 85.31 kB 85.52 kB +0.32% 26.47 kB 26.55 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.24% 691.48 kB 693.13 kB +0.20% 150.21 kB 150.51 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.24% 691.51 kB 693.16 kB +0.20% 150.23 kB 150.53 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +0.24% 754.58 kB 756.37 kB +0.18% 157.54 kB 157.83 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js +0.24% 724.25 kB 725.96 kB +0.20% 151.76 kB 152.06 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +0.24% 724.28 kB 725.99 kB +0.20% 151.78 kB 152.08 kB
oss-experimental/react-art/cjs/react-art.production.min.js +0.23% 91.96 kB 92.17 kB +0.29% 28.30 kB 28.38 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.23% 718.67 kB 720.32 kB +0.18% 155.03 kB 155.31 kB
oss-stable/react-art/cjs/react-art.development.js +0.23% 718.69 kB 720.34 kB +0.18% 155.05 kB 155.34 kB
oss-experimental/react-art/cjs/react-art.development.js +0.23% 760.04 kB 761.77 kB +0.17% 163.36 kB 163.65 kB
facebook-www/ReactDOMForked-dev.modern.js +0.22% 1,229.06 kB 1,231.80 kB +0.17% 268.34 kB 268.79 kB
facebook-www/ReactDOM-dev.modern.js +0.22% 1,229.06 kB 1,231.80 kB +0.17% 268.34 kB 268.79 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js +0.22% 92.60 kB 92.81 kB +0.29% 28.54 kB 28.63 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js +0.22% 92.63 kB 92.83 kB +0.29% 28.54 kB 28.63 kB
facebook-www/ReactDOMForked-dev.classic.js +0.22% 1,252.91 kB 1,255.65 kB +0.17% 272.86 kB 273.32 kB
facebook-www/ReactDOM-dev.classic.js +0.22% 1,252.91 kB 1,255.65 kB +0.17% 272.86 kB 273.33 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js +0.22% 97.34 kB 97.55 kB +0.24% 29.88 kB 29.95 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js +0.22% 92.85 kB 93.05 kB +0.30% 29.01 kB 29.09 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js +0.22% 92.87 kB 93.08 kB +0.29% 29.01 kB 29.09 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js +0.21% 97.58 kB 97.79 kB +0.30% 30.28 kB 30.37 kB
oss-stable-semver/react-art/umd/react-art.development.js +0.21% 823.64 kB 825.35 kB +0.16% 173.17 kB 173.44 kB
oss-stable/react-art/umd/react-art.development.js +0.21% 823.66 kB 825.38 kB +0.16% 173.18 kB 173.46 kB
oss-experimental/react-art/umd/react-art.development.js +0.21% 867.13 kB 868.93 kB +0.15% 181.55 kB 181.82 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.45 kB 0.45 kB = 0.29 kB 0.29 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.45 kB 0.45 kB = 0.29 kB 0.29 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.45 kB 0.45 kB = 0.29 kB 0.29 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.development.js = 1.05 kB 0.96 kB = 0.44 kB 0.43 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-constants.development.js = 1.05 kB 0.96 kB = 0.44 kB 0.43 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.development.js = 1.05 kB 0.96 kB = 0.44 kB 0.43 kB

Generated by :no_entry_sign: dangerJS against 651346967bcfa819e45b31ea35d562699f50feaa

sizebot avatar Oct 11 '22 23:10 sizebot

closing for now since we are starting with the other approach: https://github.com/facebook/react/pull/25700

tyao1 avatar Dec 02 '22 00:12 tyao1