react icon indicating copy to clipboard operation
react copied to clipboard

Warn when going to/from 0 hook

Open tyao1 opened this issue 2 years ago • 3 comments

Summary

For fixing #24438.

How did you test this change?

yarn test --watch ReactHooksWithnoopRenderer (--variant=true/false) yarn test --prod CI jobs

tyao1 avatar Sep 09 '22 06:09 tyao1

Comparing: c80e54116e2f9c550472116181a5c66ad97adfbf...e5440135f090aa5e0a185c7de085ef63f48213d2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 134.97 kB 134.97 kB = 43.23 kB 43.23 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 141.69 kB 141.69 kB = 45.23 kB 45.22 kB
facebook-www/ReactDOM-prod.classic.js +0.04% 486.24 kB 486.41 kB +0.06% 86.55 kB 86.60 kB
facebook-www/ReactDOM-prod.modern.js +0.04% 471.52 kB 471.69 kB +0.07% 84.32 kB 84.38 kB
facebook-www/ReactDOMForked-prod.classic.js +0.04% 486.24 kB 486.41 kB +0.06% 86.55 kB 86.60 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-dev.modern.js +1.01% 9.62 kB 9.72 kB +0.75% 2.54 kB 2.56 kB
facebook-www/ReactIs-dev.classic.js +1.01% 9.62 kB 9.72 kB +0.75% 2.54 kB 2.56 kB
facebook-www/JSXDEVRuntime-dev.modern.js +0.21% 45.70 kB 45.80 kB +0.19% 12.94 kB 12.96 kB
facebook-www/JSXDEVRuntime-dev.classic.js +0.21% 45.70 kB 45.80 kB +0.20% 12.94 kB 12.96 kB

Generated by :no_entry_sign: dangerJS against e5440135f090aa5e0a185c7de085ef63f48213d2

sizebot avatar Sep 09 '22 06:09 sizebot

Does this supersede https://github.com/facebook/react/pull/24535?

gaearon avatar Sep 09 '22 11:09 gaearon

Does this supersede https://github.com/facebook/react/pull/24535?

Yeah

tyao1 avatar Sep 09 '22 17:09 tyao1

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Apr 10 '24 01:04 github-actions[bot]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

github-actions[bot] avatar Apr 17 '24 11:04 github-actions[bot]