react icon indicating copy to clipboard operation
react copied to clipboard

Replace debug-test in documentation

Open awells111 opened this issue 1 year ago • 1 comments

Summary

yarn debug-test is now deprecated in React package.json. It has been replaced by yarn test --debug.

How did you test this change?

I've tried in both a bash console and in powershell and the result that I get from yarn debug-test is

Please run: `'yarn` instead.

From searching please run: in the repo, I found that on line 352 of scripts\jest\jest-cli.js there is the below code

  if (argv.deprecated) {
    console.log(chalk.red(`\nPlease run: \`${argv.deprecated}\` instead.\n`));
    return;
  }

I think that it's supposed to output Please run: 'yarn test --debug' but it's getting truncated, which is another problem that I can open an issue for pending the merge of this issue.

When I run yarn test --debug there are no issues and I can debug the application as expected.

awells111 avatar Jul 27 '22 14:07 awells111

Comparing: 2c7dea73659da283fa433f5fd657a5a29797fd67...7a2d1211b36a113f1137d1c067db4eee89b04a4d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 132.92 kB 132.92 kB = 42.68 kB 42.68 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 138.15 kB 138.15 kB = 44.19 kB 44.19 kB
facebook-www/ReactDOM-prod.classic.js = 469.02 kB 469.02 kB = 84.22 kB 84.22 kB
facebook-www/ReactDOM-prod.modern.js = 454.26 kB 454.26 kB = 81.98 kB 81.98 kB
facebook-www/ReactDOMForked-prod.classic.js = 469.02 kB 469.02 kB = 84.22 kB 84.22 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by :no_entry_sign: dangerJS against 7a2d1211b36a113f1137d1c067db4eee89b04a4d

sizebot avatar Jul 27 '22 14:07 sizebot