react icon indicating copy to clipboard operation
react copied to clipboard

Modified eslint error message

Open Biki-das opened this issue 1 year ago • 2 comments

Here top level errors looks a bit confusing for the developers.further they are directed to rules of hooks page and it mentions that "Hooks are called only at the top level" whereas the message reads "React hooks cannot be called at the top level".

I feel this commit clarifies the error message and also keeps it in check with the documentation

Biki-das avatar Jul 25 '22 06:07 Biki-das

Comparing: 49f8254d6dec7c6de789116e20ffc5a9401aa725...123aee6b88419b0ac278fcb1bacac9f2b113efc7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 132.92 kB 132.92 kB = 42.68 kB 42.68 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 138.15 kB 138.15 kB = 44.19 kB 44.19 kB
facebook-www/ReactDOM-prod.classic.js = 469.02 kB 469.02 kB = 84.22 kB 84.22 kB
facebook-www/ReactDOM-prod.modern.js = 454.26 kB 454.26 kB = 81.98 kB 81.98 kB
facebook-www/ReactDOMForked-prod.classic.js = 469.02 kB 469.02 kB = 84.22 kB 84.22 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by :no_entry_sign: dangerJS against 123aee6b88419b0ac278fcb1bacac9f2b113efc7

sizebot avatar Jul 25 '22 06:07 sizebot

@gnoff could you review

Biki-das avatar Jul 25 '22 17:07 Biki-das