react
react copied to clipboard
[Transition Tracing] onMarkerIncomplete - Tracing Marker Name Change
This PR adds the onMarkerIncomplete
callback for tracing marker name changes. Specifically, this PR:
- Adds the
onMarkerIncomplete
callback - When a tracing marker's name changes, call
onMarkerIncomplete
with thename
and thenewName
for the tracing marker. - call
onMarkerIncomplete
for every parent tracing marker with thename
of the tracing marker that caused the transition to be incomplete. - Don't call
onTransitionComplete
oronMarkerComplete
whenonMarkerIncomplete
is called for all tracing markers with the same transitions, but continue to callonTransitionProgress
Comparing: 19e9a4c68e16356f5079cb1d3939ac1515a9fdad...0cbae60a5c349839f48a9cd98041e717ef715c51
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
---|---|---|---|---|---|---|
oss-stable/react-dom/cjs/react-dom.production.min.js | = | 134.28 kB | 134.28 kB | = | 42.94 kB | 42.94 kB |
oss-experimental/react-dom/cjs/react-dom.production.min.js | = | 140.35 kB | 140.35 kB | = | 44.74 kB | 44.74 kB |
facebook-www/ReactDOM-prod.classic.js | +1.59% | 474.44 kB | 481.96 kB | +1.21% | 84.88 kB | 85.90 kB |
facebook-www/ReactDOM-prod.modern.js | +1.64% | 459.68 kB | 467.21 kB | +1.22% | 82.63 kB | 83.64 kB |
facebook-www/ReactDOMForked-prod.classic.js | +1.59% | 474.44 kB | 481.96 kB | +1.21% | 84.88 kB | 85.90 kB |
facebook-www/ReactART-prod.modern.js | +2.48% | 303.09 kB | 310.61 kB | +1.93% | 52.20 kB | 53.21 kB |
facebook-www/ReactART-prod.classic.js | +2.40% | 313.92 kB | 321.45 kB | +1.86% | 54.03 kB | 55.04 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
---|---|---|---|---|---|---|
facebook-www/ReactART-prod.modern.js | +2.48% | 303.09 kB | 310.61 kB | +1.93% | 52.20 kB | 53.21 kB |
facebook-www/ReactART-prod.classic.js | +2.40% | 313.92 kB | 321.45 kB | +1.86% | 54.03 kB | 55.04 kB |
facebook-www/ReactDOM-prod.modern.js | +1.64% | 459.68 kB | 467.21 kB | +1.22% | 82.63 kB | 83.64 kB |
facebook-www/ReactDOMForked-prod.modern.js | +1.64% | 459.68 kB | 467.21 kB | +1.23% | 82.63 kB | 83.64 kB |
facebook-www/ReactDOM-prod.classic.js | +1.59% | 474.44 kB | 481.96 kB | +1.21% | 84.88 kB | 85.90 kB |
facebook-www/ReactDOMForked-prod.classic.js | +1.59% | 474.44 kB | 481.96 kB | +1.21% | 84.88 kB | 85.90 kB |
facebook-www/ReactDOM-profiling.modern.js | +1.54% | 489.52 kB | 497.05 kB | +1.27% | 87.01 kB | 88.11 kB |
facebook-www/ReactDOMForked-profiling.modern.js | +1.54% | 489.52 kB | 497.05 kB | +1.27% | 87.01 kB | 88.11 kB |
facebook-www/ReactDOM-profiling.classic.js | +1.49% | 504.35 kB | 511.87 kB | +1.26% | 89.32 kB | 90.44 kB |
facebook-www/ReactDOMForked-profiling.classic.js | +1.49% | 504.35 kB | 511.87 kB | +1.26% | 89.32 kB | 90.45 kB |
facebook-www/ReactART-dev.modern.js | +1.07% | 822.65 kB | 831.42 kB | +0.86% | 173.40 kB | 174.89 kB |
facebook-www/ReactART-dev.classic.js | +1.05% | 832.87 kB | 841.64 kB | +0.85% | 175.49 kB | 176.98 kB |
facebook-www/ReactDOMForked-dev.modern.js | +0.73% | 1,194.26 kB | 1,203.03 kB | +0.58% | 261.37 kB | 262.88 kB |
facebook-www/ReactDOM-dev.modern.js | +0.73% | 1,194.26 kB | 1,203.03 kB | +0.58% | 261.37 kB | 262.88 kB |
facebook-www/ReactDOMForked-dev.classic.js | +0.72% | 1,217.87 kB | 1,226.64 kB | +0.56% | 265.84 kB | 267.33 kB |
facebook-www/ReactDOM-dev.classic.js | +0.72% | 1,217.87 kB | 1,226.65 kB | +0.56% | 265.84 kB | 267.33 kB |
Generated by :no_entry_sign: dangerJS against 0cbae60a5c349839f48a9cd98041e717ef715c51