react
react copied to clipboard
facebook
[DevTools] Manifest version 2 is deprecated
Website or app
https://developer.chrome.com/blog/mv2-transition/
Repro steps
Use latest React DevTools with Electron (Chromium) (18.2.0 / Chromium 100)
(node:80082) ExtensionLoadWarning: Warnings loading extension at ./node_modules/electron-devtools-vendor/extensions/react-developer-tools:
Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details.
How often does this bug happen?
Every time
DevTools package (automated)
No response
DevTools version (automated)
No response
Error message (automated)
No response
Error call stack (automated)
No response
Error component stack (automated)
No response
GitHub query string (automated)
No response
Redux DevTools issue for reference/inspiration/impact: https://github.com/reduxjs/redux-devtools/issues/1037
Hey! Thanks so much for the heads up! We've added it to our plans for this year. 😊
@lunaruan I would love to work on this issue. Kindly assign this issue to me.
@DhairyaBahl that would be nice! When do you plan to start working on it?
To my knowledge, the last time we investigated manifest v3 – there were blockers for our adopting it. I think maybe the run_at option was missing the "document_start" maybe but I'm not sure?
@mondaychen I will start exploring this issue soon. Since I am a new contributor to React, successful PR may take some time. If this issue needs to be resolved on urgent basis then do let me know.
@bvaughn haven't tested but at least it's still in the V3 docs https://developer.chrome.com/docs/extensions/mv3/content_scripts/#run_time
@DhairyaBahl there's a timeline for the migration: https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/ We don't want to wait until last minute... I think for now we hope to get it done by September. That's plenty of time if you are starting now. You can follow the README under the extension package folder to get started. Let me know if you need help!
@DhairyaBahl Oh no sorry! We thought you weren't because we hadn't heard from you in awhile (sorry people drop out a lot in OSS!). I'll assign this to you instead 😊
Do you know when you'd get around to it, just so we know when to reassign this if needed?
Do you know when you'd get around to it, just so we know when to reassign this if needed?
Actually @lunaruan I was going through this issue and 've been reading the contributor docs and lots of other docs just to have bit more clarity on this issue coz I am contributing to React for the first time. So, it may take a while before I can make a PR but 'll try to make a PR within a week or two. Hope you understand.
Thanks 🙂
@DhairyaBahl That works for us! Thanks so much for volunteering to help out!
@lunaruan @mondaychen I am facing problem in building react in Windows. Everything is working perfectly in Linux but even the yarn command is not working on windows and is showing this error.
Kindly help me out with this one.
Thanks 🙂
@DhairyaBahl are you working on Windows because you no longer have access to your Linux machine? Just wanna make sure because you only need to build it on one OS. Which yarn command was this?
@mondaychen I was working on linux server and i don't think that electron will work properly on linux VM. So, I decided to build and test everything on my host OS i.e. windows. I executed yarn command in the root folder of this project and got the error. just to mention, I am still having access to my linux server.
@DhairyaBahl I'll try set up a Windows VM in a minute. Just curious why do you need to run the electron app? This task is about building the extension, I don't think you would touch anything that would break the electron app
@mondaychen I thought that I will have to test my changes on electron to check if the warning is still there or not. So, that's why I preferred windows gui coz over there, I will be able to check these changes easily.
@DhairyaBahl OK that makes sense. But I'd say that's the last step. I believe you can test everything in Chrome.
Hi @Tran-Quyen this issue has been assigned to @DhairyaBahl. @DhairyaBahl do you have any updates?
Hi @Tran-Quyen this issue has been assigned to @DhairyaBahl. @DhairyaBahl do you have any updates?
Thank for your reply. How can i contribute with your repository.
@lunaruan Is this issue open??? Please assign this issue to me???
Folks, this issue is already assigned to someone else. I’d you’d like to submit a PR, no one is stopping you, but you only have to scroll up a few messages to see that the issue is already claimed.
@lunaruan Hey , It has been +2 weeks with no progress. Can you assign it back to me?
@Hanaffi I've assigned it to you. Please keep us updated with anything you have. Thanks.
@mondaychen Hello, I am new to open source contributions and don't actually know how to grab my first issue to resolve. So can you please help me out with the same? Here's my mail: [email protected] please reply here or on my mail as I don't know whether GitHub has a chat feature. Thank you in advance and I look forward to getting a reply from you.
@mondaychen Ops , Sorry wasnt notified that I was assigned to it. Will handle it.