react icon indicating copy to clipboard operation
react copied to clipboard

Test :Add a small test for ReactTestUtils to find rendered component with type in document

Open Biki-das opened this issue 3 years ago • 8 comments

I tried to write test for the ReactTestUtils to find rendered component with type in document

Tests before this PR

Windows PowerShell 4_13_2022 11_35_24 PM

Tests after this PR

Windows PowerShell 4_13_2022 11_35_30 PM

Biki-das avatar Apr 13 '22 18:04 Biki-das

Comparing: 168da8d55782f3b34e2a6aa0c4dd0587696afdbd...ddc77ac7b88520f114191353f8a85788d32a4e48

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.43 kB 131.43 kB = 42.05 kB 42.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.70 kB 136.70 kB = 43.64 kB 43.64 kB
facebook-www/ReactDOM-prod.classic.js = 435.12 kB 435.12 kB = 79.88 kB 79.88 kB
facebook-www/ReactDOM-prod.modern.js = 420.12 kB 420.12 kB = 77.51 kB 77.51 kB
facebook-www/ReactDOMForked-prod.classic.js = 435.12 kB 435.12 kB = 79.88 kB 79.88 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by :no_entry_sign: dangerJS against ddc77ac7b88520f114191353f8a85788d32a4e48

sizebot avatar Apr 13 '22 18:04 sizebot

@gaearon could you. Review?

Biki-das avatar Apr 13 '22 19:04 Biki-das

Seems good to me, surprised that we don't have a test like this already.

Also added some tests one month back to the react ART package too 😀 https://github.com/facebook/react/pull/23195

Biki-das avatar Apr 14 '22 15:04 Biki-das

hey @rickhanlonii is it good to go , or there are some nits?

Biki-das avatar Apr 18 '22 07:04 Biki-das

@gaearon friendly ping :-)

Biki-das avatar Apr 22 '22 20:04 Biki-das

See #21309

worldwidebaby avatar May 03 '22 05:05 worldwidebaby

@lunaruan could you review?

Biki-das avatar May 25 '22 17:05 Biki-das

hey @sebmarkbage could you review!

badajack avatar Aug 17 '22 15:08 badajack

hey @eps1lon seems like this can go forward as it's already been approved looking forward to your thoughts

Biki-das avatar Feb 17 '23 04:02 Biki-das