facebook
Update Yarn to version Berry
Summary
I upgraded to yarn v4.0.0, which would not work anymore on nodejs <18.
How did you test this change?
Not everything works at the moment so I make the PR a draft.
Current Issues:
- [x] We're facing many fails due to issue https://github.com/yarnpkg/berry/issues/3996... Hoping that it will resolve soon
Upgrading to Yarn 3 is blocked by the lack of Dependabot support: https://github.com/dependabot/dependabot-core/issues/1297
Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297
Ok no problem, meanwhile I will fix workflows...
Can I suggest yarn upgrade-interactive as an alternative solution?
Comparing: 2655c9354d8e1c54ba888444220f63e836925caa...7f9136f81d25890c933d38efec983739339105cb
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Generated by :no_entry_sign: dangerJS against 7f9136f81d25890c933d38efec983739339105cb
Upgrading to Yarn 3 is blocked by the lack of Dependabot support: dependabot/dependabot-core#1297
That's not true... I didn't enable pnp so there would not be problems with this type of issue.
Dependabot is not compatible with Yarn 3’s yarn.lock format. Unfortunately, it does not work with nodeLinker: node-modules too.
Update. Dependabot had started to support Yarn 2+ since 20 Oct 2022: https://github.blog/changelog/2022-10-20-dependabot-can-now-generate-security-and-version-updates-for-yarn-v2-and-v3/ Also the issue for Yarn 3 support in dependabot is now closed: https://github.com/dependabot/dependabot-core/issues/5322
Edit. Though at the time being there are still many pending issues with basic Yarn 2+ features: https://github.com/dependabot/dependabot-core/issues/6092 https://github.com/dependabot/dependabot-core/issues/6107
Update. Dependabot had started to support Yarn 2+ since 20 Oct 2022: https://github.blog/changelog/2022-10-20-dependabot-can-now-generate-security-and-version-updates-for-yarn-v2-and-v3/ Also the issue for Yarn 3 support in dependabot is now closed: dependabot/dependabot-core#5322
Edit. Though at the time being there are still many pending issues with basic Yarn 2+ features: dependabot/dependabot-core#6092 dependabot/dependabot-core#6107
Great! I wasn't more following this pr, now i will rebase, let's see what's happening with yarn 4 too
To check if the lockfiles are updated, i use this script (fishshell)
for file in (find . -name "yarn.lock" | grep -v "node_modules")
set dir (dirname $file)
echo $dir
cd $dir
rm -rf node_modules .yarn yarn.lock
wget https://raw.githubusercontent.com/facebook/react/main/{$dir}/yarn.lock
yarn
yarn dedupe # just in case you are interested into deduping lockfiles.
prevd
end
The size diff is too large to display in a single comment. The CircleCI job contains an artifact called 'sizebot-message.md' with the full message.
Generated by :no_entry_sign: dangerJS against 87e59ab6cd7f45bbcbd06d56e47dc2f72a2666bd
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}