react icon indicating copy to clipboard operation
react copied to clipboard

chore: support devEngines node 17.x

Open sudongyuer opened this issue 2 years ago • 2 comments

support devEngines node 17.x

Summary

support devEngines node 17.x

How did you test this change?

sudongyuer avatar Nov 14 '21 02:11 sudongyuer

Comparing: c0c71a868560b3042847722659579418bfe2d7e1...0b38606170e2663f6021f9d3546cf40522862a2f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.68 kB 129.68 kB = 41.46 kB 41.46 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.66 kB 134.66 kB = 42.94 kB 42.94 kB
facebook-www/ReactDOM-prod.classic.js = 424.11 kB 424.11 kB = 78.18 kB 78.18 kB
facebook-www/ReactDOM-prod.modern.js = 412.66 kB 412.66 kB = 76.43 kB 76.43 kB
facebook-www/ReactDOMForked-prod.classic.js = 424.11 kB 424.11 kB = 78.18 kB 78.18 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by :no_entry_sign: dangerJS against 0b38606170e2663f6021f9d3546cf40522862a2f

sizebot avatar Nov 14 '21 02:11 sizebot

This PR can probably closed, as 17.x appears to have already been added to devEngines in:

  • https://github.com/facebook/react/commit/4072bdfd6d1fcebe520e114e04047e06992af839

0xdevalias avatar Jul 12 '22 10:07 0xdevalias

Fixed by 4072bdfd6d1fcebe520e114e04047e06992af839 already, thanks!

kassens avatar Oct 03 '22 14:10 kassens