Deprecate SyntheticKeyboardEvent.{charCode,keyCode,which}

[japgolly]

The following KeyboardEvent properties have been officially deprecated:

• https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/charCode
• https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
• https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/which

React should probably mark these as deprecated too, and issue warnings in development mode.

[stale[bot]]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[japgolly]

bump

On Sat, 8 Aug 2020 at 17:41, stale[bot] [email protected] wrote:

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/facebook/react/issues/18873#issuecomment-670839887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRRN23KOLE2M7GRH2CFITR7T6TLANCNFSM4M4T3PTQ .

[gaearon]

What is the motivation? Even if the browser calls them deprecated they won’t be removed, right? As too much code probably depends on them.

[stale[bot]]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[tychenjiajun]

If you're using typescript. They are already marked as deprecated in d.ts https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/v16/index.d.ts

[github-actions[bot]]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[github-actions[bot]]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!