react icon indicating copy to clipboard operation
react copied to clipboard

[Umbrella] Releasing Suspense

Open acdlite opened this issue 5 years ago β€’ 118 comments

Let's use this issue to track the remaining tasks for releasing Suspense to open source.

Last updated: March 24, 2022

Blog post: The Plan for React 18

Completed: React 16

  • [x] Release <Suspense> with React.lazy for client-side lazy loading

Completed: React 18 Alpha

  • [x] Implement concurrent rendering, which is a prerequisite to everything else.
  • [x] Fix fundamental flaws in the concurrency model that made the behavior difficult to understand and caused many bugs.
  • [x] Rewrite how React traverses the tree to unblock fixing Suspense quirks.
  • [x] Redesign how React integrates with the scheduler to simplify the model, fix bugs, and prepare for native browser scheduling.
  • [x] Fix <Suspense> quirks: Previously, effects would fire inside a suspended tree too early. For example, you would see an effect from a component that's still hidden behind a placeholder. Now effects will run only after the content has been revealed. We expect this to fix existing application code bugs.
  • [x] Hiding and showing existing content should re-fire layout effects: If a component that's already visible suspends, we show a placeholder, and later show it again. However, there was no way for the component to know that it was hidden or shown. For example, a tooltip component measuring its screen position would get incorrect measurements while it's hidden. Now we fire useLayoutEffect cleanup (same as componentWillUnmount) on "hide", and useLayoutEffect setup (same as componentDidMount) on "show". We expect this to fix existing application and library code bugs.
  • [x] <Suspense> on the server no longer throws: It used to be a hard error to render <Suspense> in a tree on the server. Now, for the old server renderer, it silently emits the fallback (and lets the client try to render the content instead). This shouldn't affect existing apps because previously it was not possible to render <Suspense> on the server at all.
  • [x] startTransition lets you avoid hiding existing content even if it suspends again. This is useful to implement the "show old data while refetching" pattern with minimal code.
  • [x] Built-in throttling of Suspense reveals: To avoid updating the screen too often and causing visual jank, React "waits" a little bit before revealing the next level of spinners β€” in case even more content is available by that time. In other words, revealing nested Suspense fallbacks is automatically throttled by React.
  • [x] New Streaming Suspense Server Renderer:
    • [x] Initial streaming renderer implementation.
    • [x] React.lazy works with SSR out of the box.
    • [x] Streaming HTML: React uses your <Suspense> boundaries to stream the page HTML in visual chunks.
    • [x] Selective Hydration: React uses your <Suspense> boundaries to hydrate the page in chunks, improving responsiveness.
      • [x] React prioritizes hydrating the part of the page you are interacting with.
      • [x] React keeps the browser responsive during hydration of <Suspense> boundaries.
      • [x] React captures and replays missed events after hydration.
  • [x] Technical preview of Server Components:
    • [x] Implement the server with support for suspending.
    • [x] Prototype a caching layer.
    • [x] Prototype React I/O libraries like react-fetch and react-pg.
    • [x] Support lazy-loaded elements for server trees.

Completed: React 18

  • [x] Finalize New Streaming Suspense Server Renderer:
    • [x] Make it pass all of our existing tests.
    • [x] Prove it out in production (currently we use a hack in its place).
    • [x] Add the missing "static markup" APIs for things like emails.
    • [x] Fix known bugs with hydrating Suspense.
    • [x] Move the new server renderer from react-dom/unstable-fizz to react-dom/server.
  • [x] Fall back to client rendering from closest <Suspense> on mismatches instead of patching up the tree.
  • [x] Add onRecoverableError to gather production reports about SSR mismatches.

Features that may or may not appear in 18.x

  • [ ] <SuspenseList> lets you declaratively coordinate the order in which <Suspense> nodes inside will reveal.
    • [x] Implementation.
    • [ ] Server support
    • [ ] Finalize and document the API.
  • [ ] "Backup" <Suspense> boundaries (not final naming): A way to specify that you'd like React to ignore this boundary during initial render (as if it's not there), unless React is forced to hide existing content. We sometimes call these "ugly spinners" or "last resort spinners". This use case might seem a bit exotic but we've needed it quite a few times.
    • [x] Initial implementation as unstable_avoidThisFallback
    • [x] Server support
    • [ ] Pick a good name
  • [ ] <Suspense> for CPU-bound trees (not final naming): A way to tell React to immediately show a placeholder without even trying to render the content. This is useful if you have an expensive tree inside. This use case is unrelated to network β€” it's about showing a spinner for some tree that takes a while to render. See https://github.com/facebook/react/pull/19936.
    • [x] Initial implementation as unstable_expectedLoadTime
    • [ ] Adjust the heuristics
    • [x] Server support
    • [ ] Pick a good name
  • [ ] An API to prioritize hydrating a particular DOM element's parent tree.
    • [x] Implement as ReactDOM. unstable_scheduleHydration
    • [ ] Pick a name
  • [ ] Reducing jank: Take another look at adjusting the small details to reduce any visual jank to the minimum. For example, throttle reveal of Suspense boundaries between siblings as well.

React 18.x (post-18.0): Suspense for Data Fetching

All of the above changes are foundational architectural improvements to <Suspense>. They fill the gaps in the mechanism and make it deeply integrated with all parts of React (client and server). However, they don't prescribe a particular data fetching strategy. That will likely come after the 18.0 release, and we're hoping that to have something during the next 18.x minor releases.

This work will include:

  • [ ] React I/O libraries like react-fetch, which is a lightweight and easiest way to fetch data with Suspense.
    • [x] Initial implementation
    • [ ] Finalize the API
  • [ ] Built-in Suspense <Cache> which will likely be the primary recommended way for third-party data fetching libraries to integrate with Suspense. (For example, react-fetch uses it internally.)
    • [x] Initial implementation
    • [ ] Try it in production
    • [ ] Investigate what's missing
    • [ ] Figure out the recommended strategy for normalized caches
  • [ ] Server Components, which will be the recommended way to fetch data with Suspense in a way that scales great and integrates with React Fetch as well as third-party libraries.
    • [x] Initial implementation
    • [x] Basic Server Context implementation
    • [ ] Server Context features for refetching
    • [ ] Figure out the layering between Server Components and New SSR
    • [ ] (This section has many follow-up questions, so it's incomplete)
  • [ ] Clear documentation and recommendations for data fetching library authors on how to integrate with Suspense

acdlite avatar Jul 13 '18 20:07 acdlite

Expose unstable_AsyncMode (maybe?)

Isn't this already exposed?

aweary avatar Jul 13 '18 20:07 aweary

I meant remove the unstable_

acdlite avatar Jul 13 '18 20:07 acdlite

I am looking forward to open source of the unnamed code-splitting library πŸ’―

thoamsy avatar Jul 15 '18 01:07 thoamsy

What does it mean [Umbrella]?πŸ€”β˜‚οΈ

ryota-murakami avatar Jul 23 '18 06:07 ryota-murakami

This mean, it's a feature which impact several projects/packages/tools.

ghoullier avatar Jul 23 '18 07:07 ghoullier

@ghoullier I see, Thank you so much!

ryota-murakami avatar Jul 23 '18 07:07 ryota-murakami

Hey @acdlite, just a question about how to best prepare for this. Not asking for / expecting any kind of timeline, but wondering:

Are you currently expecting these features to drop into React 16 and be easy to adopt incrementally, like the new Context API that landed with 16.3?

Or are you thinking it'll be something that pushes React to v17 and require more work to adopt?

Asking because I'm working on a roadmap that crosses over significantly with pretty much everything on your list and am trying to work out how to best deal with that.

Also do you have any tips on how to best prepare (in terms of code written today, that wants to be future compatible with these improvements to React) - polyfills / techniques / etc?

(apologies if these questions are answered elsewhere and I've missed them)

JedWatson avatar Jul 24 '18 02:07 JedWatson

Adding another question to @JedWatson's questions:

  • We also don't need/expect to get a timeline for a stable release, but would it be possible/useful to get a new prerelease? (AFAIK the newest release is 16.4.0-alpha.0911da3 from February.)

Thank you! ❀️

donaldpipowitch avatar Jul 24 '18 13:07 donaldpipowitch

IMO, they will provide a blog post like before before it's been landed.

And I think you don't need to prepare too much because there is no breaking change(it does have many features that maybe would seems different/conflict with current practices, like redux fetch with suspense, but there will be a codemod or easy encapsulation to do this, you know, fb has 3W+ components). And if you watch the talk of @acdlite (about ssr suspense in ZEIT) and @gaearon (about client suspense in iceland), you will know you don't need to worry about too much and it's not invasive.

By the way, you can just search the key 'Umbrella' in the repo and you will find more info like #8830 and #12152

AFAIK the newest release is 16.4.0-alpha.0911da3 from February.

IIRC, this is a misoperation?

NE-SmallTown avatar Jul 24 '18 14:07 NE-SmallTown

@JedWatson This comment helped me understand what a developer must do to help ensure that their application's are async safe.

sebinsua avatar Jul 24 '18 16:07 sebinsua

I'm working on rolling out the suspense module and new APIs in facebook. In case @acdlite is busy with something else, I'd like to share some of my thoughts of our experience in facebook and answer some questions of @JedWatson.

Are you currently expecting these features to drop into React 16 and be easy to adopt incrementally, like the new Context API that landed with 16.3?

I'm not sure if it will come with React 16 or 17. According to the React team, it's likely to be released before the end of this year, which depends on how well it runs in facebook and how the related API is ready or not. But code-wise, I'm happy to say that it would be easy to adopt, because we've been experimenting for quite a while in facebook. The suspense feature will still work for the existing codebase. But with additional changes (like async rendering), you'll have more bonus that the new feature will bring you.

Do you have any tips on how to best prepare (in terms of code written today, that wants to be future compatible with these improvements to React) - polyfills / techniques / etc?

I'd say the migration is rather incremental and progressive. Like @NE-SmallTown said, we don't want to introduce any breaking changes. That would also be painful to roll out to facebook because we have a so large codebase. But so far, the roll out has been smooth and doesn't require you to do additional changes.

cyan33 avatar Jul 24 '18 17:07 cyan33

@JedWatson

Are you currently expecting these features to drop into React 16 and be easy to adopt incrementally, like the new Context API that landed with 16.3?

Incrementally. Always incrementally :) Otherwise there's no way we'd be able to ship this at Facebook.

Here's what I'm expecting:

Client Server-side rendering
Suspense Works everywhere* Same constraints as existing server renderer
Async rendering Opt-in using <AsyncMode> Same constraints as existing server renderer

*In sync mode, delayMs is always 0. Placeholders show up immediately.

Suspense will work without any changes to your existing components. At one point we thought we might require <StrictMode> compatibility, but during our internal testing we discovered one of the best ways to upgrade to strict mode was to use Suspense. Chicken-egg dilemma. So we found a way to make it work even outside of strict mode.

So the idea is that users will start migrating to Suspense even before they're ready to migrate to asynchronous rendering. Then once a subtree is ready, they can opt-in by wrapping in <AsyncMode>.

For new apps, though, the story is different: go async by default. We'll introduce a new root API (a replacement for ReactDOM.render) that is async only.

There will be an awkward period after the initial release where many third-party frameworks (Redux, Apollo, React Router...) may not work properly in async mode. That might hurt adoption for a while. But the idea is that the new features will be so compelling that it won't take long for libraries to either adapt or be superseded by an async-compatible alternative.

Also do you have any tips on how to best prepare (in terms of code written today, that wants to be future compatible with these improvements to React) - polyfills / techniques / etc?

Wrap everything in <StrictMode> and make sure there are no warnings. We'll have more detailed migration guides as we get closer to release.

acdlite avatar Jul 24 '18 20:07 acdlite

There will be an awkward period after the initial release where many third-party frameworks (Redux, Apollo, React Router...) may not work properly in async mode.

Apollo doesn't do awkward - we'll be ready! πŸ•ΊπŸ˜³

Seriously though, we :heart: all things React, so making sure we're in-line with these changes for the initial release is not only a high priority, but it's also something we're super excited about! Thanks for all of your amazing work on this @acdlite!

hwillson avatar Jul 25 '18 11:07 hwillson

I'll chime in and say that the Redux team is working on async compat for React-Redux.

I laid out a potential roadmap at https://github.com/reduxjs/react-redux/issues/950 . TL;DR:

  • React-Redux 5.1 will hopefully work with <StrictMode> with no warnings (current PR: https://github.com/reduxjs/react-redux/pull/980 )
  • 6.0 will be an internal rewrite to use the new context API, add ref forwarding, and possibly other changes, but try to keep as much of the current public API as possible (ie, <Provider> and connect() ). We'll see how well that works with async rendering, and figure out the best path forward. (My prior proof-of-concept PR is at https://github.com/reactjs/react-redux/pull/898 , but we'll probably redo it based on other lessons learned from the 5.1 work.) It's likely that this release would require React 16.5 as a minimum, due to the need for new context and probably also the as-yet unreleased "read context from lifecycle methods" PR that was just merged.
  • After that, we're open to ideas for a different React-Redux API (yes, yes, that possibly includes render props, people).

We'd appreciate more eyes on our WIP, and hopefully people can give us some more feedback and discussion on how they're looking at using Redux with React Suspense and async rendering so we can make sure use cases get covered properly. We're also hoping to have some more discussions with the React team about exactly what constraints we need to work with, and it'd be helpful if we could get some sample apps that would let us see what problems we need to solve for all this to work correctly.

markerikson avatar Jul 25 '18 16:07 markerikson

looking forward to the release of Async rendering and Suspense

anymost avatar Jul 26 '18 05:07 anymost

@acdlite Also question about suspense and async rendering. My question is once they are introduced and one starts writing apps with that new version of react: does it mean that react API and the way people code in react will change too? (even if they don't plan to use features of suspense and async rendering?)

I assume it can be trickier to write react code with suspense and async rendering (maybe due to some new API or other constraints), and for those who don't need it, why force them to use react in a new way? And not allow them to code in react the way they do now?

ghost avatar Jul 27 '18 19:07 ghost

I assume it can be trickier to write react code with suspense

Have you had a chance to watch the second half of my talk? I'd say quite the opposite β€” it's way less trickier to use suspense for data fetching than anything else (including Redux, local state, or some other library).

gaearon avatar Jul 27 '18 20:07 gaearon

@gaearon I haven't. I was speaking more in theory. Imagine there is already set of people who know react. If people don't need the feature of async rendering and suspense, why force them learn "new" react? Especially if the "new" react is tricker to use? But: I am not well informed so I might be wrong say about the "trickier" part - I am just sharing some of my thoughts :).

In a way I am saying if 10% of apps need the feature of Suspense and async rendering, why in those other 90% cases force people to learn "new" react? But again I might be wrong, since I didn't gather much info about suspence and async rendering yet.

ghost avatar Jul 27 '18 21:07 ghost

I think it's hard to have a conversation if you haven't looked at my demos yet.

To be clear: there's no "new React", these features don't break any existing patterns πŸ™‚. They are additive. You don't need to write code in a completely different way to use those features either β€” although some of them only work if you use modern lifecycle methods.

While this is not directly related to your concern, I disagree they're "trickier to use". I think suspense is much simpler to use than any other loading mechanism that currently exists. That's the reason I'm so excited about it. But again, you don't have to use any of the new features if you don't want to. Old patterns will keep working.

I really do recommend watching my talk. I'm sure this will make a lot more sense once you see these features in action.

gaearon avatar Jul 27 '18 21:07 gaearon

@gaearon

All old patterns keep working.

Thanks for feedback Dan. Yeah that is how I thought, I suppose if people don't need those features they should be able to write the way they used to before those features were added.

good luck.

ghost avatar Jul 27 '18 21:07 ghost

Hey Dan(@gaearon), I am not nitpicking but want to figure it out. Above you said:

But again, you don't have to use any of the new features if you don't want to. Old patterns will keep working.

Which would suggest that I can code in new React the same way I did in "old" React, e.g. I could use the life cycle methods in the same way, etc. right?

However, here, bvaughn says that getDerivedStateFromProps (or componentWillReceiveProps) could be called many times for one update, hence his solution not to fetch data inside it.

So my question is, after all, it does seem we can't use the new React in exactly the same way as before right? Because AFAIK in current react componentWillReceiveProps doesn't get called many times for one update, isn't it?

ghost avatar Aug 18 '18 17:08 ghost

@giorgi-m : yes, the lifecycle methods are changing, but the point is that Suspense itself is an opt-in feature. All your existing React render methods and React's rendering behavior will work as-is. However, if you opt in by adding an <AsyncMode> tag to a part of your app, and you begin using Suspense's approach for indicating async data needs, then you can take advantage of it. None of that happens if you don't add that to your codebase.

markerikson avatar Aug 18 '18 18:08 markerikson

@giorgi-m componentDidUpdate should be used instead of componentWillReceiveProps or getDerivedStateFromProps.

TrySound avatar Aug 18 '18 18:08 TrySound

@markerikson So you say that what bvaughn said here, that getDerivedStateFromProps can be called many times for one update, is not necessarily the case, if I haven't enabled the <AsyncMode/>? (sorry for asking such questions just they popup to me from time to time, and didn't find resource which would cover all).

ps. bvaughn also didn't mention the optionality of that in the linked thread, hence it raised my suspicion.

ghost avatar Aug 18 '18 18:08 ghost

Should a method for enqueueing asynchronous updates (e.g. deferSetState() for class components as opposed to renderer-specific unstable_deferredUpdates()) be added to the core checklist?

From my understanding, any updates for fibers in async mode will be asynchronous, which in theory means that deferSetState() would be unnecessary. However, the unstable-async/suspense demo mixes a synchronous update and an async update and I'm not sure how that can be accomplished in async mode (for "universal" components).

pshrmn avatar Aug 22 '18 20:08 pshrmn

It’s in the check list for the time slicing umbrella.

gaearon avatar Aug 22 '18 20:08 gaearon

Support promise as a component type

Related to this, when you have:

const PromiseType = new Promise(() => {})
class A extends Component {
	componentDidMount() {}
	componentDidUpdate() {}
	render() {
		return <div><PromiseType></PromiseType></div>
	}
}

Are there any heuristics as to when componentDidMount and componentDidUpdate lifecycles would get called.

  1. When all children have been resolved(including the promise), which in this case means they won't get called given the promise is never resolved?
  2. When all Immediate host children have been rendered?

thysultan avatar Aug 27 '18 19:08 thysultan

@thysultan : componentDidMount and componentDidUpdate are called in the commit phase, when a UI tree has been fully rendered and applied to the DOM.

So, based on my understanding of Suspense, I think the answer is that the A instance would never actually mount. If PromiseType did get resolved, but one of its further descendants also attempted to wait for a promise that never resolves, it would again never mount. Thus, cDM and cDU would never be executed in those examples.

(Someone feel free to correct me if my assumptions are wrong here :) )

markerikson avatar Aug 27 '18 19:08 markerikson

Yea, componentDidMount or componentDidUpdate only execute in the commit phase which only executes after the whole tree has been resolved. This tree might include some placeholders that you've explicitly put there (depending on whether something inside them still suspends after we've waited long enough) β€” but if you explicitly render a child without a placeholder around it, you can never end up in a situation where it's "not ready".

gaearon avatar Aug 27 '18 21:08 gaearon

I am really looking forward to being able to play with this (even browsed through a lot of source code only to figure out you hadn't put a working version of this on the world wide web yet).

Is there anything we can do to help get this released? :D

Kingdutch avatar Aug 28 '18 14:08 Kingdutch