react-strict-dom icon indicating copy to clipboard operation
react-strict-dom copied to clipboard
verified publisher icon facebook

Implement <svg> support

Open efoken opened this issue 10 months ago • 3 comments

https://github.com/facebook/react-strict-dom/issues/4

efoken avatar Feb 19 '25 09:02 efoken

Let me know what you think @necolas

There are still some $FlowFixMe that I added inside createStrictDOMSvgComponent which can be fixed by changing the NativeProps type, but I was not sure if that's the best place, or if it may be better to have a bit more differentiation between React Native Props and React Native SVG Props.

Also I am willing to add some tests and probably some examples in the Expo examples app.

efoken avatar Feb 19 '25 11:02 efoken

This PR is great timing! I just happened to do something similar in my app via a patch and was playing with it before sending a PR. Thanks moving so quickly on it.

nandorojo avatar Feb 26 '25 22:02 nandorojo

Is something causing any trouble that we could fix to move forward with this ?

MoOx avatar May 16 '25 15:05 MoOx