react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Move ShadowNodeFamily to PropsAnimatedNode

Open bartlomiejbloniarz opened this issue 1 month ago • 11 comments

Summary: This diff is a part of the process of getting the Animated-itest to work with Animation Backend. During testing I found that sometimes the disconnect method would cleanup tagToShadowNodeFamily_ when there were more than one PropsAnimatedNode for a view, so we would wrongly skip an animation. By storing the family pointer on the props node we can avoid that.

Differential Revision: D89042963

bartlomiejbloniarz avatar Dec 12 '25 16:12 bartlomiejbloniarz

@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89042963.

meta-codesync[bot] avatar Dec 12 '25 16:12 meta-codesync[bot]

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 :x: Build Scan not published

github-actions[bot] avatar Dec 12 '25 16:12 github-actions[bot]

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 :x: Build Scan not published

github-actions[bot] avatar Dec 12 '25 16:12 github-actions[bot]

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 :x: Build Scan not published

github-actions[bot] avatar Dec 12 '25 16:12 github-actions[bot]

This pull request was successfully merged by Bartlomiej Bloniarz in d91de9646e58f48918c81dbc410fe8bac9816c49

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Dec 16 '25 15:12 react-native-bot

This pull request was successfully merged by Bartlomiej Bloniarz in 8267a59bdab8eeaa49f0ee32da64ab33526678d9

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Dec 16 '25 17:12 react-native-bot

Warnings
:warning:

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: NON_BREAKING

Generated by :no_entry_sign: dangerJS against 8267a59bdab8eeaa49f0ee32da64ab33526678d9

react-native-bot avatar Dec 16 '25 17:12 react-native-bot

This pull request was successfully merged by Bartlomiej Bloniarz in 9227dd7975ab073841e9f435989695575365bf94

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Dec 17 '25 10:12 react-native-bot

This pull request was successfully merged by Bartlomiej Bloniarz in 93f7feb4d3227d95210cd027619e58fd796f6512

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Dec 18 '25 15:12 react-native-bot

Job Summary for Gradle

Test All :: run_fantom_tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
react-native-github :private:react-native-fantom:buildFantomTester 9.0.0 :x: Build Scan not published

github-actions[bot] avatar Dec 18 '25 15:12 github-actions[bot]

This pull request was successfully merged by Bartlomiej Bloniarz in daee5a4190c21cdbc5710ca3b25522e04e5aa6a3

When will my fix make it into a release? | How to file a pick request?

react-native-bot avatar Dec 19 '25 14:12 react-native-bot