facebook
Possibly solve the issue with TalkBack order
Solving issue #45096
Summary:
Change the order of setter in onInitializeAccessibilityNodeInfo and ensure the getTalkbackDescription return correct text for TalkBack
-
The order of TalkBack is not set correctly due to the way that we use setter in the method onInitializeAccessibilityNodeInfo. (It can be found in packages/react-native/ReactAndroid/src/main/java/react/ReactAccessibilityDelegate.java The method goes from top to bottom and the setters was in order of: setRole -> setTooltipText -> setLabeledBy -> setState -> addAction -> setCollectionItemInfo ->setRangeInfo
-
I also update the getTalkbackDescription to return the correct order of text for TalkBack by returning the talkbackSegments at once instead of keep checking twice
Hi @dnhan1707!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Fix is not needed because of https://github.com/facebook/react-native/issues/45096#issuecomment-2457490142
