facebook
WIP: Fix #18945 inverted sticky headers (footers actually) not working issue
Summary:
Fix #18945 inverted sticky headers (footers actually) not working issue
Changelog:
[General] [Fixed] - Fix SectionList sticky footer doesn't work as expected when the list has inverted flag set
Test Plan:
https://github.com/user-attachments/assets/3dc9b2ed-bc0d-4e47-94af-0878653498bd
Added a test sample file. I tested it in an Android emulator and it appears to be working fine. I haven't test other stuff or platform yet. Here's a screencast of the demo:
https://github.com/user-attachments/assets/3dc9b2ed-bc0d-4e47-94af-0878653498bd
Okay, tested with iOS simulator. It appears to be working as expected
https://github.com/user-attachments/assets/c3e46ad0-8d0c-4db5-8061-d06244e5fb40
Hey @migueldaipre, @cortinico and @cipolleschi, I've fixed the failing tests. Can you please help me kick start the CI job again as it appears requiring to be kicked started by repo maintainers.
hmm, okay, looks like some other tests are still failling 😅 will find a time to fix those soon
Hi @migueldaipre, @cortinico and @cipolleschi, sorry about that. I updated the branch and ran test locally and it seems to be passing now. As for failing linter action, I didn't see anything from the messages look like causing by my changes. Is it suppose to fail regardless? If so, can you please help me trigger the CI action again? Thank you so much 🙏
I just realized that the linter failure is not caused by linter, it was actually prettier changes a few lines 😅 I have already run prettier and commit the changes. Should have all the CI action passes at this point
/cc @migueldaipre, @cortinico and @cipolleschi
Somehow after rebased tests and linter failed again 😅 Sorry about that, let me check, rebased, and run them locally again to see if they pass or not
Okay, the flow error should be addressed now. Really sorry for repeating this many times 🙈 Hopefully this time there won't be other CI task failed, I run the known failed ones locally and they all seems like passing now. Finger cross 🤞
@migueldaipre, @cortinico and @cipolleschi
Hopefully this time there won't be other CI task failed, I run the known failed ones locally and they all seems like passing now. Finger cross 🤞
The CI is still red though 🤔
How about your work on your fork till you get the CI from GitHub actions on your fork green and then get back to the PR?
@cortinico sorry, I forgot to pushed my fixes for broken CI😅 Can you please help me run it on the CI one final time, if it still somehow fails, I will then setup GitHub action in my forked repo. Really sorry for the troubles 🙇♀️
Really sorry for the troubles 🙇♀️
No need to be sorry 🙏
Also just a small heads up: I'll be off for some weeks and I wasn't able to find a reviewer for this change internally, so this might have to wait some time before we can import/merge it
Haha, a bit embarrassing that the CI kept failing 😅 Looks like they all passed finally.
No worries, please enjoy your time off, and take your time. 🙏
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
I hate to be that guy but … is there anything we can do to make this happens ? 😬 @fangpenlin
Sorry, I haven't had the time to work on this. This change is also a bit delicate as it requires us to change some of the internal code and it will affect other Meta apps, so it is not just as easy as importing and landing.
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity.