react-native icon indicating copy to clipboard operation
react-native copied to clipboard

fix bottom of modal being cutoff

Open alanleedev opened this issue 5 months ago • 1 comments

Summary: Issue: When running on Android 15, content of the modal is cut-off at the bottom (content seems to overlap with bottom navigation bar and is cut-off)

  • Android 15, even without building with targetSdk 35, seems to introduce behavior change so add code to handle such case
  • also fix existing logic that seems like it just happened to work before but is no longer working with Android 15
    • only call updateState() when needed
    • add padding for Android 15

drawback:

  • padding for Android 15 does leave a gap at the bottom when gesture navigation bar is used instead of 3 button navigation bar
    • this is necessary for now since when device runs Android 15 existing Modal will break without any update
    • plan to add an opt-out prop so users can opt-out of auto-padding and handle edge-to-edge properly using safe-area-context lib
  • does not attempt to fix existing issue with gap at bottom when statusbarTranslucent prop is set to true

Changelog: [Android][Fixed] - Modal content cut-off at bottom on Android 15

Differential Revision: D62179031

alanleedev avatar Sep 04 '24 23:09 alanleedev