react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Make ReactImageView use standardized background drawing code

Open NickGerleman opened this issue 1 year ago • 2 comments

Summary: This updates ReactImageView to share the background drawing and clipping code used by other built-in components. This means manipulating a background drawable, and clippping at draw time, instead of using Fresco hierarchy background (in view foreground), and radii which manipulate the underlying bitmap.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D59495407

NickGerleman avatar Jul 10 '24 22:07 NickGerleman

This pull request was exported from Phabricator. Differential Revision: D59495407

facebook-github-bot avatar Jul 10 '24 22:07 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,284,418 +54
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,481,407 +52
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2932c0f71f1882607d9e579e5c09db28e131a4c9 Branch: main

analysis-bot avatar Jul 10 '24 23:07 analysis-bot

This pull request has been merged in facebook/react-native@52dc7a832666532b457bda736c5fe4095f31f731.

facebook-github-bot avatar Jul 11 '24 10:07 facebook-github-bot

This pull request was successfully merged by @NickGerleman in 52dc7a832666532b457bda736c5fe4095f31f731.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Jul 11 '24 10:07 github-actions[bot]