react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Fix SurfaceMountingManager leaking activity from stopped surfaces

Open javache opened this issue 9 months ago • 2 comments

Summary: The issue is very similar to D46840717.

MountingManager will keep a reference to the last 15 stopped surfaces: https://fburl.com/code/kbjw0a3x Each stopped surface still holds a mRemoveDeleteTreeUIFrameCallback which references activity:

{F1638417601}

Differential Revision: D57367419

javache avatar May 15 '24 15:05 javache

This pull request was exported from Phabricator. Differential Revision: D57367419

facebook-github-bot avatar May 15 '24 15:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,526,263 +11
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,896,195 +67
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 044aadbaf6830b21aab821804dc5a7989010022e Branch: main

analysis-bot avatar May 15 '24 16:05 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D57367419

facebook-github-bot avatar May 17 '24 21:05 facebook-github-bot

This pull request has been merged in facebook/react-native@af721084afd5ba530e47fb353e8e5b1c4d9f56b7.

facebook-github-bot avatar May 17 '24 23:05 facebook-github-bot

This pull request was successfully merged by Oleh Malanchuk in af721084afd5ba530e47fb353e8e5b1c4d9f56b7.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar May 17 '24 23:05 github-actions[bot]