react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Factor hardcoded image paths out in RNTester/Image example, get rid of .ico file

Open rshest opened this issue 9 months ago • 3 comments

Summary:

Changelog:

[Internal] -

RNTester Image example used hardcoded https://www.facebook.com/favicon.ico, which has an uncommon ICO format, for no good reason aside of just this image being served from facebook.com.

This diff:

  • Replaces the ICO image with a PNG one (which is still served from facebook.com
  • Factors out all the multiple hardcoded paths into constants, so that it's easier to make such changes in the future
  • Changes another image to something that is a bit better on the eyes when severely downscaled

Differential Revision: D56978929

rshest avatar May 05 '24 09:05 rshest

This pull request was exported from Phabricator. Differential Revision: D56978929

facebook-github-bot avatar May 05 '24 09:05 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,495,289 +275
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,867,610 +39
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a881b51febd1fd809bc9d4fd368a1833f4c850c6 Branch: main

analysis-bot avatar May 05 '24 10:05 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D56978929

facebook-github-bot avatar May 05 '24 10:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56978929

facebook-github-bot avatar May 05 '24 15:05 facebook-github-bot

This pull request has been merged in facebook/react-native@362abb9ffea5af7e6e5616849fbce28166c758a0.

facebook-github-bot avatar May 05 '24 20:05 facebook-github-bot