react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Hoist TextInput.autoCapitalize to BaseTextInputProps on C++ side

Open rshest opened this issue 9 months ago • 1 comments

Summary:

Changelog:

[Internal]-

Even though TextInput.autoCapitalize is supposed to be cross-platform, on the C++ side of the props data structures it was only exposed as an Android-specific one.

This would have it still work on the iOS side (as the corresponding prop is passed to Objective C around the C++ structs anyway), however it may also cause subtle scenarios, whereas the prop changes dynamically on the iOS side, but this doesn't get reflected on the native side.

This change fixes this problem by simply hoisting the prop into the BaseTextInputProps, which makes it available across all platforms, as it should be.

Differential Revision: D56726940

rshest avatar Apr 29 '24 21:04 rshest

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,444,913 -14
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,817,862 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b7de91666453b832b889d9577226097aeeace1a8 Branch: main

analysis-bot avatar Apr 29 '24 22:04 analysis-bot

Merged as https://github.com/facebook/react-native/commit/7b3c622219ff6c03f410d34b06a74ba6fd642f5b

javache avatar Jun 27 '24 20:06 javache