react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[CodeQL] Fix comparison of narrow type with wide type in loop condition in RawPropsKeyMap.cpp

Open marlenecota opened this issue 9 months ago • 2 comments

Summary:

We ran CodeQL in react-native-windows and it found a comparison of narrow type with wide type in loop condition in ReactCommon/react/renderer/core/RawPropsKeyMap.cpp

microsoft/react-native-windows#12701

Changelog:

[INTERNAL] [SECURITY] - Fix comparison of narrow type with wide type in loop condition in RawPropsKeyMap.cpp

Test Plan:

Tested on windows.

marlenecota avatar Apr 25 '24 20:04 marlenecota

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,443,705 -16,342
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,817,158 -16,366
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2876fae8d3674d34c5461482a8f021791ba1c97e Branch: main

analysis-bot avatar Apr 25 '24 21:04 analysis-bot

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 26 '24 10:04 facebook-github-bot

@javache merged this pull request in facebook/react-native@b53c4395ce1ce1f0bc3fd972fc5c1d63cf6c3d33.

facebook-github-bot avatar Apr 26 '24 15:04 facebook-github-bot

This pull request was successfully merged by @marlenecota in b53c4395ce1ce1f0bc3fd972fc5c1d63cf6c3d33.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 26 '24 15:04 github-actions[bot]