react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Defines module for React-jsinspector

Open Kudo opened this issue 1 year ago • 1 comments

Summary:

Defines module for React-jsinspector that for swift modules to integrate with.

to fix https://github.com/expo/expo/issues/28209, any podspec depends on HermesExecutorFactory should use add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern') to add dependency. otherwise it will encounter the header not found issue because use_frameworks will change "jsinspector-modern" to "jsinspector_modern".

to depend on React-jsinspector from expo-modules-core, we need it to define as a module. otherwise, it will have the error

The Swift pod `ExpoModulesCore` depends upon `React-jsinspector`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

Changelog:

[IOS] [CHANGED] - Add DEFINES_MODULE for React-jsinspector.podspec

Test Plan:

ci passed

Kudo avatar Apr 25 '24 11:04 Kudo

@cipolleschi could you help to take a look for this change when you get a chance?

Kudo avatar Apr 25 '24 12:04 Kudo

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 25 '24 14:04 facebook-github-bot

@cipolleschi merged this pull request in facebook/react-native@4e6186555eac8e98724e5027a882c92ee195652d.

facebook-github-bot avatar Apr 25 '24 15:04 facebook-github-bot

This pull request was successfully merged by @Kudo in 4e6186555eac8e98724e5027a882c92ee195652d.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 25 '24 15:04 github-actions[bot]