react-native icon indicating copy to clipboard operation
react-native copied to clipboard

add PopupMenuDismissEvent

Open alanleedev opened this issue 11 months ago • 3 comments

Summary: Deprecated UIManager.showPopupMenu() had success callback that would be triggered on 1) item selection or 2) dismiss. New PopupMenuAndroid only has item selection callback so adding in missing dismiss callback.

Changelog: [Android][Added] - Add (optional) onPopupDismiss() callback for PopupMenuAndroid

Reviewed By: cortinico

Differential Revision: D55531870

alanleedev avatar Apr 02 '24 16:04 alanleedev

This pull request was exported from Phabricator. Differential Revision: D55531870

facebook-github-bot avatar Apr 02 '24 16:04 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,918,807 +4,241
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,283,308 +79
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 76a29fc8e788635f60cdda553bcd2b2a941fa548 Branch: main

analysis-bot avatar Apr 02 '24 17:04 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D55531870

facebook-github-bot avatar Apr 03 '24 16:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D55531870

facebook-github-bot avatar Apr 04 '24 07:04 facebook-github-bot

This pull request has been merged in facebook/react-native@bc3e3360d1bd3fde9ab4d28c49757e3db0dad7f9.

facebook-github-bot avatar Apr 04 '24 09:04 facebook-github-bot

This pull request was successfully merged by @alanleedev in bc3e3360d1bd3fde9ab4d28c49757e3db0dad7f9.

When will my fix make it into a release? | How to file a pick request?

github-actions[bot] avatar Apr 04 '24 09:04 github-actions[bot]