react-native
react-native copied to clipboard
facebook
[Android] [Fix]:-Unify onMomentumEnd callback behaviour in android with iOS
Summary:
There is a specific divergent occuring on the onmomentunscrollend occuring in android , the same callback does not called when using the scrolltooffset, in short when we try to scroll programatically , the onmomentumscrollend does not get called, the issue is limited to android and things work fine in iOS
https://github.com/facebook/react-native/assets/72331432/2bf02da5-6424-421a-bab8-9d1f6d3176c0
Changelog:
[ANDROID] [FIXED] - Unify onMomentumEnd callback behaviour in android with iOS
Test Plan:
Added updated RN tester examples to demonstrate the scroll behaviour when done programatically
https://github.com/facebook/react-native/assets/72331432/bd3fc994-ab51-4940-9c2a-66385fd06cb0
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 19,385,676 | +411 |
| android | hermes | armeabi-v7a | n/a | -- |
| android | hermes | x86 | n/a | -- |
| android | hermes | x86_64 | n/a | -- |
| android | jsc | arm64-v8a | 22,760,578 | +316 |
| android | jsc | armeabi-v7a | n/a | -- |
| android | jsc | x86 | n/a | -- |
| android | jsc | x86_64 | n/a | -- |
Base commit: 99d0c540cac42efec2ab5943b8d0510bbf94e16b Branch: main
@hoxyq could you help shedding some light on this one!, someone who could review this potentially and give some feedback!
@hoxyq could you help shedding some light on this one!, someone who could review this potentially and give some feedback!
Thanks for flagging, usually we get notified when CI jobs are green on PR, so its ready for a review
Unfortunately this is out of my area of expertise for React Native, cc @NickGerleman @javache who might have opinion on this
@hoxyq could you help shedding some light on this one!, someone who could review this potentially and give some feedback!
Thanks for flagging, usually we get notified when CI jobs are green on PR, so its ready for a review
Unfortunately this is out of my area of expertise for React Native, cc @NickGerleman @javache who might have opinion on this
wow! thats good to know! thanks for the reply!