react-native
react-native copied to clipboard
Update TypeScript types for `Libraries/Core/Devtools` to match implementation
Summary:
The parseErrorStack function takes the stack as a string, as its only argument, not the Error: https://github.com/facebook/react-native/blob/ce4d8f2756841e1226cb1c773026413b63abdf85/packages/react-native/Libraries/Core/Devtools/parseErrorStack.js#L41
The symbolicateStackTrace returns a promise of an object containing a codeFrame and stack, not an array of frames:
https://github.com/facebook/react-native/blob/ce4d8f2756841e1226cb1c773026413b63abdf85/packages/react-native/Libraries/Core/Devtools/symbolicateStackTrace.js#L17-L30
Changelog:
[GENERAL] [FIXED] - Fixed TypeScript type of the parseErrorStack and symbolicateStackTrace functions to match their implementation.
Test Plan:
I patched the file locally and tested function to ensure its callable with a string.
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
I believe this is still relevant.
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
Needs a rebase, but the still seem wrong on main if the implementation wasn't adjusted since.