fix(iOS): fix rendering `RCTRedBoxExtraData`

[krozniata]

trafficstars

Summary:

This PR fixes rendering of RCTRedBoxExtraData

I noticed that it wasn't displaying the reload and dismiss buttons, which made it impossible to close modal and to reload JS on e.g. visionOS (on iOS it could only be closed by swiping).

PR adds these buttons back and also introduces some refactoring

Before & After:

Changelog:

[IOS] [FIXED] - Fix rendering RCTRedBoxExtraData

Test Plan:

Make sure that RCTRedBoxExtraData displays and works as expected

[lunaleaps]

Could you clarify what broke and how this fixes it?

[krozniata]

@lunaleaps Sure! Before, when user opened the "Extra data" section in RedBox it was impossible to reload JS from it, because due to a bug in the layout, buttons were not visible and the modal could only be dismissed by dragging it down (which wasn't possible to do in visionOS, so it couldn't be dismissed at all).

This PR brings back the missing buttons by fixing the RCTRedBoxExtraData layout, as they were already added before, they just weren't visible.

[krozniata]

@lunaleaps Is there anything else that's needs to be done to get this PR merged?

[Biki-das]

@krozniata could you show me when this appears with an example? like the bug

[krozniata]

@cipolleschi 👀

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in facebook/react-native@c9d589dab5148cbd192078967f743d38b8048c6e.

[github-actions[bot]]

This pull request was successfully merged by @krozniata in c9d589dab5148cbd192078967f743d38b8048c6e.

^{When will my fix make it into a release? | How to file a pick request?}