react-native icon indicating copy to clipboard operation
react-native copied to clipboard

add rows props to TextInput.d.ts

Open ashaller2017 opened this issue 1 year ago • 4 comments

Summary:

I am currently building a mobile app and upgrade to react-native 0.73. I was annoyed when my IDE kept signaling errors that certain props are not valid on TextInputProps when extended on interfaces I'm using. I just want to add a few of the props that already exist in the js file for TextInput but are missing in the ts file leading to annoying IDE warnings/errors.

Changelog:

[ANDROID] [ADDED] - just added rows to the TextInput.d.ts so that when passing props IDE's will not be confused.

Test Plan:

Nothing is breaking. Simple add to props on the typescript file of what is already declared and used in the TextInput.js file.

ashaller2017 avatar Feb 17 '24 23:02 ashaller2017

Hi @ashaller2017!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 17 '24 23:02 facebook-github-bot

Warnings
:warning:

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

:warning:

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

:warning:

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

Generated by :no_entry_sign: dangerJS against 24dbf53ac88b6f769511e83498a31335a00dffb6

github-actions[bot] avatar Feb 17 '24 23:02 github-actions[bot]

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,500,332 -9,381,217
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,754,914 -11,485,117
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8ff05b5a18db85ab699323d1745a5f17cdc8bf6c Branch: main

analysis-bot avatar Feb 17 '24 23:02 analysis-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Feb 18 '24 00:02 facebook-github-bot

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

react-native-bot avatar Aug 16 '24 05:08 react-native-bot