react-native
react-native copied to clipboard
[iOS][KeyboardAvoidingView] Using KeyboardAvoidingView inside a ScrollView causes the app the crash when focusing an input
Description
When KeyboardAvoidingView
inside a ScrollView
and focus a TextInput
the app crashes (goes extremely slow).
This seems to only happen if the KeyboardAvoidingView
needs to trigger the animation, if the ScrollView is small it works fine.
Testing with react native 0.72.9
the issue doesn't seem to happen
Steps to reproduce
- install the app
yarn ios
- Using the simulator make sure the keyboard shows when entering a text input
- Focus a text input and start typing on the keyboard
- Dismiss the keyboard / click outside of the input
- You will notice the app has now hung
React Native Version
0.73.4
Affected Platforms
Runtime - iOS
Output of npx react-native info
System:
OS: macOS 14.2.1
CPU: (10) arm64 Apple M1 Max
Memory: 127.84 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.18.2
path: ~/.nvm/versions/node/v18.18.2/bin/node
Yarn:
version: 1.22.21
path: ~/.nvm/versions/node/v18.18.2/bin/yarn
npm:
version: 9.8.1
path: ~/.nvm/versions/node/v18.18.2/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.14.3
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- visionOS 1.0
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8309675
Xcode:
version: 15.2/15C500b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.9
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.73.4
wanted: 0.73.4
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
### Stacktrace or Logs
```text
Excessive number of pending callbacks: 501. Some pending callbacks that might have leaked by never being called from native code: {"235":{"module":"UIManager","method":"configureNextLayoutAnimation"},"238":{"module":"UIManager","method":"configureNextLayoutAnimation"},"241":{"module":"UIManager","method":"configureNextLayoutAnimation"},"244":{"module":"UIManager","method":"configureNextLayoutAnimation"},"247":{"module":"UIManager","method":"configureNextLayoutAnimation"},"250":{"module":"UIManager","method":"configureNextLayoutAnimation"},"253":{"module":"UIManager","method":"configureNextLayoutAnimation"},"256":{"module":"UIManager","method":"configureNextLayoutAnimation"},"259":{"module":"UIManager","method":"configureNextLayoutAnimation"},"262":{"module":"UIManager","method":"configureNextLayoutAnimation"},"265":{"module":"UIManager","method":"configureNextLayoutAnimation"},"268":{"module":"UIManager","method":"configureNextLayoutAnimation"},"271":{"module":"UIManager","method":"configureNextLayoutAnimation"},"274":{"module":"UIManager","method":"configureNextLayoutAnimation"},"277":{"module":"UIManager","method":"configureNextLayoutAnimation"},"280":{"module":"UIManager","method":"configureNextLayoutAnimation"},"283":{"module":"UIManager","method":"configureNextLayoutAnimation"},"286":{"module":"UIManager","method":"configureNextLayoutAnimation"},"289":{"module":"UIManager","method":"configureNextLayoutAnimation"},"292":{"module":"UIManager","method":"configureNextLayoutAnimation"},"295":{"module":"UIManager","method":"configureNextLayoutAnimation"},"298":{"module":"UIManager","method":"configureNextLayoutAnimation"},"301":{"module":"UIManager","method":"configureNextLayoutAnimation"},"304":{"module":"UIManager","method":"configureNextLayoutAnimation"},"307":{"module":"UIManager","method":"configureNextLayoutAnimation"},"310":{"module":"UIManager","method":"configureNextLayoutAnimation"},"313":{"module":"UIManager","method":"configureNextLayoutAnimation"},"316":{"module":"UIManager","method":"configureNextLayoutAnimation"},"319":{"module":"UIManager","method":"configureNextLayoutAnimation"},"322":{"module":"UIManager","method":"configureNextLayoutAnimation"},"325":{"module":"UIManager","method":"configureNextLayoutAnimation"},"328":{"module":"UIManager","method":"configureNextLayoutAnimation"},"331":{"module":"UIManager","method":"configureNextLayoutAnimation"},"334":{"module":"UIManager","method":"configureNextLayoutAnimation"},"337":{"module":"UIManager","method":"configureNextLayoutAnimation"},"340":{"module":"UIManager","method":"configureNextLayoutAnimation"},"343":{"module":"UIManager","method":"configureNextLayoutAnimation"},"346":{"module":"UIManager","method":"configureNextLayoutAnimation"},"349":{"module":"UIManager","method":"configureNextLayoutAnimation"},"352":{"module":"UIManager","method":"configureNextLayoutAnimation"},"355":{"module":"UIManager","method":"configureNextLayoutAnimation"},"358":{"module":"UIManager","method":"configureNextLayoutAnimation"},"361":{"module":"UIManager","method":"configureNextLayoutAnimation"},"364":{"module":"UIManager","method":"configureNextLayoutAnimation"},"367":{"module":"UIManager","method":"configureNextLayoutAnimation"},"370":{"module":"UIManager","method":"configureNextLayoutAnimation"},"373":{"module":"UIManager","method":"configureNextLayoutAnimation"},"376":{"module":"UIManager","method":"configureNextLayoutAnimation"},"379":{"module":"UIManager","method":"configureNextLayoutAnimation"},"382":{"module":"UIManager","method":"configureNextLayoutAnimation"},"...(truncated keys)...":451}
### Reproducer
https://github.com/slauzinho/KeyboardAvoidingViewExample
### Screenshots and Videos
https://github.com/facebook/react-native/assets/445345/72aa333e-f55a-446f-aea5-6b7615b8a4ca
@lunaleaps I can reproduce this issue using the reproducer mentioned in the description https://github.com/slauzinho/KeyboardAvoidingViewExample.
@cortinico same issue.
Moving KeyboardAvoidingView over a ScrollView fixed my problem with crashing application when clicking on an input (IOS)
The crash was happening when publishing the app and on real device.
Guideline 2.1 - Performance - App Completeness
We discovered one or more bugs in your app. Specifically, login screen was unresponsive. Please review the details below and complete the next steps.
Review device details:
- Device type: iPad Air (5th generation)
- OS version: iOS 17.3.1
Kindly check this key in scrollview overScrollMode='never' @kokosky93
Kindly check this key in scrollview overScrollMode='never' @kokosky93
overScrollMode
is an Android prop shouldn't really matter in this case
That's true. Setting overScrollMode didn't help.
i dont think its crash, its loop cause mis-use of element. in this case keyboardawarescroll in scrollview; when keyboard is open its trigger to keyboardawarescroll to extend bottom height and put keyboard down and thats circle trigger to scrollview because layout change and also scrollview extends layout and keyboardawarescroll again try to put keyboard to bottom so extend layout and again triggered scrollview.
Even i prevent this loop keyboardawarescroll its not working properly, can't arrange keyboard position and content because scrollview.
Related part KeyboardAvoidingView.js:
// update bottom height for the first time or when the height is changed
if (!oldFrame || oldFrame.height !== this._frame.height) {
await this._updateBottomIfNecessary();
}
Any updates? Also experiencing this - v0.73.4
Experiencing the same issue here! RN v0.73.4 as well. The issue indeed seems to be related to being inside a ScrollView
, and on top having the behaviour set to padding
, like so:
<KeyboardAvoidingView behavior="padding">
When setting the behaviour to position
, there is no problem.
<KeyboardAvoidingView behavior="position">
Edit: added more details
I tried @Navaie's solution. It seems to be a bit more stable but crashes anyway when fiddling with the input + scrollview. For now, we're removing KeyboardAvoidingViews completely
Like @kokosky93 , my workaround was to swap the component order to make the KeyboardAvoidingView
the parent element of the ScrollView
, then add a new child View
for applying container styles that were previously on the KeyboardAvoidingView
.
So far, everything seems to be working as intended.
I also observed that this issue only affected distributions running on real iOS devices. Not reproducible in either ExpoGo or Android builds.
Experiencing the same issue here! RN v0.73.4 as well. The issue indeed seems to be related to being inside a
ScrollView
, and on top having the behaviour set topadding
, like so:<KeyboardAvoidingView behavior="padding">
When setting the behaviour to
position
, there is no problem.<KeyboardAvoidingView behavior="position">
Edit: added more details
Thanks buddy! Works! Yes, must change behavior to ="position", else will not scroll.
We were running into this as well and have temporarily removed the KeyboardAvoidingView
that was triggering this.
Thanks
Experienced the same thing, I had <KeyboardAvoidingView/>
inside of a <SafeAreaView/>
. It works on the iOS Emulator, on Android simulator and device, it only "freezes" on real iOS device. I'm following this conversation now.
"react-native": "0.73.6"
Experiencing the same thing here as well. 0.73.6
Any updates in regards to this issue?
I'm facing this same issue too, using <KeyboardAvoidingView/>
inside of a <SafeAreaView/>
.
It only freezes on a real iOS device (not all iOS devices either, so far I've been able to reproduce this issue on iPhone SE running latest iOS) - but unable reproduce on simulator/android.
Update: Flipping the sequence so that SafeAreaView is encapsulated by KeyboardAvoidingView seems to resolve it - confirmed after testing.
"react-native": "0.73.7"
@shahidrogers If the issue happens solely because of the <SafeAreaView/>
, then you can try to use the useSafeAreaInsets
hook instead.
Still happens with react native 0.74.1
I think I’m experiencing something similar with TextInput inside of a KeyboardAvoidingView on react native 0.74.1.
Same here.. 0.74.1
Same issue here. Problem seems to appear only on "small" device: working perfectly on iPhone 11, crashing on iPhone 13 mini.
I'm currently trying to implement this PR in local before it get merged:
https://github.com/facebook/react-native/pull/44652
Same issue here. Problem seems to appear only on "small" device: working perfectly on iPhone 11, crashing on iPhone 13 mini.
I'm currently trying to implement this PR in local before it get merged:
#44652
tried this change locally, seems not working for me. v0.73.8
Glad this is being fixed. Its super frustrating because it only appears when uploaded to test flight. I couldn't reproduce the error in my development build.
Same issue here. Problem seems to appear only on "small" device: working perfectly on iPhone 11, crashing on iPhone 13 mini.
I'm currently trying to implement this PR in local before it get merged:
#44652
I think I'm facing the same issue with an iPad (10th gen) and an iPhone 11 so not only small devices. Besides, I have an iPhone 15 that doesn't encounter this bug. I'm working with [email protected]
Edit: my problem might not be completely related to this so don't rely too much on it but while I was fixing my issue i discovered that I had packed ScrollView into ScrollView (nestedScrollEnabled={false}) into KeyboardAvoidingView into ScrollView into KeyboardAvoidingView. I did fix this disaster to have only ScrollV into KeyboardAV, but I noticed somewhere else where it remains a SV into KAV into SV into KAV and it doesn't bug/freeze so ¯\_(ツ)_/¯