react-native
react-native copied to clipboard
facebook
Bump Flipper to 0.204.0
Summary:
Bumped Flipper version from 0.182.0 to 0.204.0 (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see here for more context.
Changelog:
[Android] [Changed] - Bump Flipper to 0.204.0
Test Plan:
CI Green ✅
Hm, looks like the artifacts for Android are not published. Same for iOS side, where the latest version published is 0.202.0, but the latest version released on is 0.204.0 ;(
v0.196.0 and after also remove Flipper's Yoga dependency, which should let us clean up the iOS build quite a bit.
Cc. @cortinico: I don't think we can bump Flipper: IIRC, the new version of Flipper requires an NDK we do not support yet. And we don't want to have two different versions of Flipper for iOS and Android, right?
I am seeing
v0.201.0available on Maven central for Android. Still a very recent build.
Yeah, but the flipper-fresco-plugin is still on 0.182.0.
Cc. @cortinico: I don't think we can bump Flipper: IIRC, the new version of Flipper requires an NDK we do not support yet. And we don't want to have two different versions of Flipper for iOS and Android, right?
This bump is because we would like to bump NDK version in RN and it is necessarily to bump Flipper to version which contains NDK 25. See here for more context.
@szymonrybczak please use: https://repo1.maven.org/maven2/com/facebook/flipper/flipper/0.201.0/
As for Fresco, we need to update to use this one instead: https://repo1.maven.org/maven2/com/facebook/fresco/flipper-fresco-plugin/3.0.0/ (it depends on Flipper 0.183.+)
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 8,831,836 | +1 |
| android | hermes | armeabi-v7a | 8,140,637 | +3 |
| android | hermes | x86 | 9,336,254 | +1 |
| android | hermes | x86_64 | 9,178,908 | +2 |
| android | jsc | arm64-v8a | 9,444,735 | +3 |
| android | jsc | armeabi-v7a | 8,626,097 | +2 |
| android | jsc | x86 | 9,526,953 | +2 |
| android | jsc | x86_64 | 9,770,309 | +1 |
Base commit: 0f85be8f667a36ee052b887f56256679ad422f14 Branch: main
CI Green ✅
@NickGerleman I deleted the Yoga port from post_install and from tests, mind looking at this again? 🙏
CI Green ✅
@NickGerleman I deleted the Yoga port from
post_installand from tests, mind looking at this again? 🙏
Thanks for doing this. There is some more cleanup we can do around Yoga headers, but that’s best for a separate change.
I will let @cortinico do a final review, but the YogaKit changes otherwise look good to me since we no longer pull in the dependency.
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cortinico merged this pull request in facebook/react-native@d9c8cd3b4051ecb9230a44289f9cf026b954ecdb.