react-native fix: return the correct default trait collection

fix: return the correct default trait collection

Open alanjhughes opened this issue 1 year ago • 1 comments

Summary:

Currently, when the _currentColorScheme is nil the default comes from [UITraitCollection currentTraitCollection] which provides the trait collection of the context it was called in. Generally, this will work but in some cases the context can be different and this will return the wrong value also if the Appearance property is set in the plist, then initially that value is returned, regardless of if you have overridden it. Seen as the userInterfaceStyle of the window is overridden when the value is changed, then the default should be whatever the current style of the window is and not dependent on the calling context.

Before	After

Changelog:

[IOS] [FIXED] - Fix the default trait collection to always return the value of the window

Test Plan:

Tested on rn-tester and verified the current behaviour is unaffected and also in our own repo to make sure it addresses the problem. Video provided above

Jul 06 '23 09:07 alanjhughes

Platform Engine Arch Size (bytes) Diff

android hermes arm64-v8a 9,061,546 +4

android hermes armeabi-v7a 8,310,881 +3

android hermes x86 9,577,764 +2

android hermes x86_64 9,420,185 +3

android jsc arm64-v8a 9,613,324 +5

android jsc armeabi-v7a 8,739,959 +5

android jsc x86 9,700,289 +2

android jsc x86_64 9,946,838 -1

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,061,546	+4
android	hermes	armeabi-v7a	8,310,881	+3
android	hermes	x86	9,577,764	+2
android	hermes	x86_64	9,420,185	+3
android	jsc	arm64-v8a	9,613,324	+5
android	jsc	armeabi-v7a	8,739,959	+5
android	jsc	x86	9,700,289	+2
android	jsc	x86_64	9,946,838	-1