react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Actions] Bump `needs-attention` to `v2.0.0`

Open Pranav-yadav opened this issue 1 year ago • 11 comments

Summary:

This diff bumps hramos/needs-attention to v2.0.0 v2.0.0 is a latest BREAKING release with a number of improvements made by @Pranav-yadav i.e. me 😎

P.S. Just to have node16 across RN workflows I did that work 🤣 and released the v2 :)

Major Improvements:

  • Bump Node.js to v16
  • Bump actions/checkout to v3
  • Add TypeScript
  • Generate and publish fully compiled dist (with deps) instead of node_modules

Ref.:

  • Full Changelog for v2.0.0: https://github.com/hramos/needs-attention/releases/tag/v2.0.0
  • Marketplace v2.0.0: https://github.com/marketplace/actions/needs-attention?version=v2.0.0

Changelog:

[GENERAL] [SECURITY] - Bump hramos/needs-attention to v2.0.0

Test Plan

  • Workflow should add and remove respective labels as usual.

Pranav-yadav avatar Jun 24 '23 06:06 Pranav-yadav

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,885,646 +4,097
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,240,028 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8ff05b5a18db85ab699323d1745a5f17cdc8bf6c Branch: main

analysis-bot avatar Jun 24 '23 06:06 analysis-bot

/rebase

Pranav-yadav avatar Jun 28 '23 11:06 Pranav-yadav

ping @cortinico, is there anything that needs to be done from my side? Rebased :)

Pranav-yadav avatar Jun 28 '23 11:06 Pranav-yadav

ping @cortinico, is there anything that needs to be done from my side?

yup, we'd like to move needs-attention to react-native-community before merging this

cortinico avatar Jun 30 '23 09:06 cortinico

ping @cortinico, is there anything that needs to be done from my side?

yup, we'd like to move needs-attention to react-native-community before merging this

Yeah, that would be great. But, I'm not the owner, Héctor Ramos owns the repo. You may ping him.

Pranav-yadav avatar Jul 01 '23 05:07 Pranav-yadav

I've messaged him and will get back to you once we can unblock this

cortinico avatar Jul 03 '23 13:07 cortinico

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 31 '23 05:12 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Jan 07 '24 05:01 github-actions[bot]

@Pranav-yadav are you still interested in merging this? If so, we'll need to rebase + apply the suggestion I added

cortinico avatar Jan 09 '24 10:01 cortinico

/rebase

Pranav-yadav avatar Feb 17 '24 08:02 Pranav-yadav

/rebase

cortinico avatar Feb 19 '24 13:02 cortinico

This pull request has been merged in facebook/react-native@9c7742b7dbd34750537049bf2491e0f1c7ba5357.

facebook-github-bot avatar Mar 15 '24 12:03 facebook-github-bot