react-native icon indicating copy to clipboard operation
react-native copied to clipboard

GlobalPerformanceLogger: handle cases when global.performance is not yet initialized

Open rshest opened this issue 1 year ago • 2 comments

Summary:

Changelog:

[Internal] -

There is no guarantee that setUpPeformance, which establishes the global.performance object accordingly, will be always called before anything tries to use performance logging.

In fact, there is an example in FB4A with the early initialization of MobileConfige, which logs a time span to measure how long does it take to initialize.

This makes the web performance logging code safe from such scenarios.

Differential Revision: D46762527

rshest avatar Jun 15 '23 17:06 rshest

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 15 '23 17:06 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,888 +262
android hermes armeabi-v7a 8,070,464 +262
android hermes x86 9,250,492 +267
android hermes x86_64 9,099,627 +260
android jsc arm64-v8a 9,319,075 +73
android jsc armeabi-v7a 8,508,980 +73
android jsc x86 9,382,556 +65
android jsc x86_64 9,635,801 +74

Base commit: d097408c1ca15d3aa9dd69dc12f1043f54890213 Branch: main

analysis-bot avatar Jun 15 '23 18:06 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 15 '23 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 15 '23 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 15 '23 19:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 15 '23 19:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 16 '23 07:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 16 '23 10:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 16 '23 10:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 16 '23 10:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46762527

facebook-github-bot avatar Jun 16 '23 11:06 facebook-github-bot

This pull request has been merged in facebook/react-native@a4ef8b7d47d8c98a405c1637c9d9d61474e623b7.

facebook-github-bot avatar Jun 16 '23 13:06 facebook-github-bot