react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Untangle dependency loop in virtualized-lists

Open rshest opened this issue 1 year ago • 4 comments

Summary:

Changelog:

[Internal] -

I've noticed bundler spamming with cyclical dependency warnings when working on FB4A.

This gets rid of the unneeded two-way dependency between ListMetricsAggregator <-> VirtualizeUtils.

Differential Revision: D46761080

rshest avatar Jun 15 '23 13:06 rshest

This pull request was exported from Phabricator. Differential Revision: D46761080

facebook-github-bot avatar Jun 15 '23 13:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46761080

facebook-github-bot avatar Jun 15 '23 13:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46761080

facebook-github-bot avatar Jun 15 '23 13:06 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,666 +14
android hermes armeabi-v7a 8,070,245 +19
android hermes x86 9,250,275 +25
android hermes x86_64 9,099,411 +11
android jsc arm64-v8a 9,319,013 -3
android jsc armeabi-v7a 8,508,922 +7
android jsc x86 9,382,501 +7
android jsc x86_64 9,635,742 +9

Base commit: c5496fd93f3c09d72b249b8154f17af8a6df38fb Branch: main

analysis-bot avatar Jun 15 '23 14:06 analysis-bot

This pull request was exported from Phabricator. Differential Revision: D46761080

facebook-github-bot avatar Jun 15 '23 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46761080

facebook-github-bot avatar Jun 15 '23 18:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46761080

facebook-github-bot avatar Jun 16 '23 06:06 facebook-github-bot

This pull request was successfully merged by @rshest in 92525ef3aebb5b31a4af1f987ef0282d12ecb7a1.

When will my fix make it into a release? | Upcoming Releases

github-actions[bot] avatar Jun 16 '23 07:06 github-actions[bot]