react-native
react-native copied to clipboard
facebook
Parser create getTypeAnnotationName(typeAnnotation)
Summary:
[Codegen 134 - Assigned to @cloudpresser] Create a function getTypeAnnotationName(typeAnnotation) in the Parser base class. Implement it using this code for Flow and this code for Typescript. Replace the callsites with the new function.
This is part of #34872
Changelog:
[INTERNAL] [ADDED] - getTypeAnnotationName(typeAnnotation) in parser
Test Plan:
yarn jest packages/react-native-codegen > new tests written, as well as coverage from existing tests
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 8,744,588 | +3 |
| android | hermes | armeabi-v7a | 8,056,431 | +3 |
| android | hermes | x86 | 9,235,548 | +3 |
| android | hermes | x86_64 | 9,086,369 | +4 |
| android | jsc | arm64-v8a | 9,307,266 | +3 |
| android | jsc | armeabi-v7a | 8,496,489 | +1 |
| android | jsc | x86 | 9,369,139 | -2 |
| android | jsc | x86_64 | 9,624,077 | +5 |
Base commit: 0191d16712a07b092e932a43e386abff9ca2d514 Branch: main
@cipolleschi I updated this PR with changes suggested here. Also, now that upstream is fixed we're now passing CI tests here, :)
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cloudpresser I'm sorry to ask for this, I have been tried to land this change for a while, but meanwhile the state of the repo has changed. Could you please try to rebase and make sure that the CI is green again? 🙏
@cipolleschi merged this pull request in facebook/react-native@e22d1a10cb9e5318f3636a9716ea8a82d65f8d70.