react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Codegen 93] Move getOptions to parsers commons

Open tarunrajput opened this issue 1 year ago • 1 comments

Summary

[Codegen 93] The getOptions function in parsers/typescript/components/options.js and parsers/flow/components/options.js is the same. move it in parser-commons and use it in the original files. If the file two options.js files are empty, delete them.

Part of Issue #34872

Changelog

[Internal][Changed] - Move getOptions to parsers commons from parsers components options

Test Plan

yarn jest react-native-codegen

tarunrajput avatar Mar 09 '23 08:03 tarunrajput

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,193 +0
android hermes armeabi-v7a 7,834,776 +0
android hermes x86 8,999,081 +0
android hermes x86_64 8,854,121 +0
android jsc arm64-v8a 9,141,838 +0
android jsc armeabi-v7a 8,333,472 +0
android jsc x86 9,196,418 +0
android jsc x86_64 9,454,245 +0

Base commit: b9c64f3651ac87a1495acead12500d51a4938036 Branch: main

analysis-bot avatar Mar 09 '23 08:03 analysis-bot

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 09 '23 20:03 facebook-github-bot

/rebase

cipolleschi avatar Mar 13 '23 14:03 cipolleschi

/rebase

cipolleschi avatar Mar 20 '23 10:03 cipolleschi

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 20 '23 10:03 facebook-github-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 20 '23 10:03 facebook-github-bot

@cipolleschi merged this pull request in facebook/react-native@221aacd72d110f576c03773eeaef52b8e2bd5aeb.

facebook-github-bot avatar Mar 20 '23 14:03 facebook-github-bot