react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Codegen 99] Extract throwIfMoreThanOneCodegenNativecommands error in error-utils

Open tarunrajput opened this issue 1 year ago • 5 comments

Summary

Part of Codegen Umbrella Issue: #34872

[Codegen 99] Extract the throwIfMoreThanOneCodegenNativecommands error in the error-utils.js file and extract the error code from Flow and TS

Changelog

[Internal] [Changed] - Extract throwIfMoreThanOneCodegenNativecommands error in error-utils

Test Plan

yarn jest react-native-codegen

tarunrajput avatar Mar 08 '23 17:03 tarunrajput

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 08 '23 17:03 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,517,289 +0
android hermes armeabi-v7a 7,833,334 +0
android hermes x86 8,997,657 +0
android hermes x86_64 8,852,646 +0
android jsc arm64-v8a 9,141,130 +0
android jsc armeabi-v7a 8,333,010 +0
android jsc x86 9,195,927 +0
android jsc x86_64 9,453,756 +0

Base commit: 57a2508ae6e8b33fb556c1e194f81a65b6784a8f Branch: main

analysis-bot avatar Mar 08 '23 17:03 analysis-bot

/rebase

cipolleschi avatar Mar 09 '23 09:03 cipolleschi

I don't understand why CircleCI on main is passing, but it is not passing in this PR. :/ There are no Ruby-related differences...

cipolleschi avatar Mar 09 '23 10:03 cipolleschi

I don't understand why CircleCI on main is passing, but it is not passing in this PR. :/ There are no Ruby-related differences...

I see that these tests are failing in my other PR's too :(. But there are no ruby related changes

tarunrajput avatar Mar 09 '23 10:03 tarunrajput

/rebase

tarunrajput avatar Mar 09 '23 18:03 tarunrajput

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 10 '23 10:03 facebook-github-bot

/rebase

cipolleschi avatar Mar 13 '23 09:03 cipolleschi

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 13 '23 09:03 facebook-github-bot

/rebase

cipolleschi avatar Mar 13 '23 14:03 cipolleschi

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 13 '23 14:03 facebook-github-bot

/rebase

tarunrajput avatar Mar 15 '23 06:03 tarunrajput

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 15 '23 10:03 facebook-github-bot

@cipolleschi merged this pull request in facebook/react-native@347d6f8d899d7a8f5c901611923c9c09039acbdb.

facebook-github-bot avatar Mar 15 '23 14:03 facebook-github-bot