react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Add minimum necessary .d.ts files to react-native-codegen (2)

Open ZihanChen-MSFT opened this issue 1 year ago • 2 comments

Summary

  • Add .d.ts files for generators
  • export each generators because react-native-windows need its own selection of generators.

Changelog

[GENERAL] [CHANGED] - Add minimum necessary .d.ts files to react-native-codegen (2)

Test Plan

npm run build in packages/react-native-codegen and see all .d.ts files appear in lib. Checked .d.ts file in typescript playground.

ZihanChen-MSFT avatar Mar 07 '23 21:03 ZihanChen-MSFT

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,517,351 +0
android hermes armeabi-v7a 7,833,003 +0
android hermes x86 8,997,779 +0
android hermes x86_64 8,852,982 +0
android jsc arm64-v8a 9,141,144 +0
android jsc armeabi-v7a 8,332,635 +0
android jsc x86 9,195,987 +0
android jsc x86_64 9,454,035 +0

Base commit: 48c7adc3bf574c6d592e9d1c1c4bd266f88063f7 Branch: main

analysis-bot avatar Mar 07 '23 22:03 analysis-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 09 '23 10:03 facebook-github-bot

/rebase

cipolleschi avatar Mar 10 '23 11:03 cipolleschi

I think these errors must be addressed:

/home/circleci/react-native/packages/react-native-codegen/src/generators/RNCodegen.d.ts
   8:33  warning  Strings must use singlequote                                       quotes
  74:5   error    Property is optional, so `undefined` must be included in the type  redundant-undefined/redundant-undefined
  80:5   error    Property is optional, so `undefined` must be included in the type  redundant-undefined/redundant-undefined
  90:5   error    Property is optional, so `undefined` must be included in the type  redundant-undefined/redundant-undefined

cipolleschi avatar Mar 10 '23 11:03 cipolleschi

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 13 '23 14:03 facebook-github-bot

@cipolleschi merged this pull request in facebook/react-native@ac5aec3f5caa732f4565328447ffa9da7ede8dec.

facebook-github-bot avatar Mar 16 '23 10:03 facebook-github-bot