react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

FileReader#readAsArrayBuffer

Open SheetJSDev opened this issue 2 years ago • 2 comments

Summary

Fixes a number of issues with third party libraries that use Blob#arrayBuffer or FileReader#readAsArrayBuffer, including #30769 #34402 #20091 #21209

Changelog

[INTERNAL] [FIXED] - Implemented FileReader#readAsArrayBuffer

Test Plan

Added a test which fails against current release but passes after code changes.

SheetJSDev avatar Mar 01 '23 07:03 SheetJSDev

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,476,750 -82
android hermes armeabi-v7a 7,798,783 -85
android hermes x86 8,952,666 -76
android hermes x86_64 8,810,191 -82
android jsc arm64-v8a 9,108,043 +38
android jsc armeabi-v7a 8,304,769 +32
android jsc x86 9,158,834 +34
android jsc x86_64 9,418,134 +32

Base commit: a0adf57e509dbb9074b2fa14339c5add140f5332 Branch: main

analysis-bot avatar Mar 01 '23 08:03 analysis-bot

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 08 '23 13:03 facebook-github-bot

+1

lorenc-tomasz avatar Mar 14 '23 13:03 lorenc-tomasz

@javache merged this pull request in facebook/react-native@5b597b5ff94953accc635ed3090186baeecb3873.

facebook-github-bot avatar Mar 14 '23 19:03 facebook-github-bot