react-native icon indicating copy to clipboard operation
react-native copied to clipboard

chore(babel,flow): realign version bumps

Open kelset opened this issue 1 year ago • 10 comments

Summary

While working on https://github.com/facebook/react-native/pull/35786 I noticed some inconsistencies in the versioning for Babel and Flow across the monorepo. So in this PR I wanted to address that so that for 0.72 we'll have the codebase in a more consistent shape.

Happy to split in multiple PRs if needed.

Changelog

[GENERAL] [CHANGED] - Bump Babel packages to ^7.20.0 (or closest latest release), bump flow parser to 0.201 in a few places that were left out from latest bump

Test Plan

CI is green.

kelset avatar Jan 06 '23 11:01 kelset

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jan 06 '23 11:01 facebook-github-bot

Thanks! This is one of those changes that'll need aligning across Meta projects to pass internal CI - the @babel/runtime bump is a big one - but I'll see if we can make it stick.

robhogan avatar Jan 06 '23 11:01 robhogan

Thanks! This is one of those changes that'll need aligning across Meta projects to pass internal CI - the @babel/runtime bump is a big one - but I'll see if we can make it stick.

yeah no worries, I'm happy to split in multiple PRs if needed (in particular the flow aligments and the babel bump in template)

kelset avatar Jan 06 '23 12:01 kelset

@robhogan just wanted to check in how's it going for this PR - as mentioned, I'm happy to split in multiples to get as much of this in as possible right away

kelset avatar Jan 17 '23 12:01 kelset

@robhogan @cipolleschi I just gave another pass and a cleanup to this PR, is it worth keeping open or I should just close it?

kelset avatar Mar 07 '23 10:03 kelset

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,732,587 +0
android hermes armeabi-v7a 8,043,960 -1
android hermes x86 9,221,946 -4
android hermes x86_64 9,074,944 -2
android jsc arm64-v8a 9,297,786 -4
android jsc armeabi-v7a 8,486,594 -2
android jsc x86 9,358,542 -2
android jsc x86_64 9,615,143 +1

Base commit: 0a4a95f56870ba7191d8a34cd8295a91dcd232ee Branch: main

analysis-bot avatar Mar 07 '23 10:03 analysis-bot

I don't know... maybe @robhogan has more info/ideas?

cipolleschi avatar Mar 08 '23 13:03 cipolleschi

Sorry for not getting back @kelset - this is a tricky one to land because it needs syncing with a bunch of other projects outside RN. I suggest we hold it until after @hoxyq's monorepo work (which I know is bumping/syncing a few of these deps anyway) and then tidy up what's left.

robhogan avatar Mar 08 '23 13:03 robhogan

Sorry for not getting back @kelset - this is a tricky one to land because it needs syncing with a bunch of other projects outside RN. I suggest we hold it until after @hoxyq's monorepo work (which I know is bumping/syncing a few of these deps anyway) and then tidy up what's left.

Monorepo changes also include bumping yargs outside of react-native, but not in react-native-github/hermes-inspector-msggen. I think we should return to this PR next week, if monorepo won't be landed by this time, we should at least merge this PR to have in 0.72 (as stated in summary)

hoxyq avatar Mar 08 '23 13:03 hoxyq

works for me, let's keep this frozen until the monorepo PR is successfully landed 👍 thanks for the update folks

kelset avatar Mar 08 '23 14:03 kelset

allright, branch rebased and updated! lmk what you want to do with it folks 🤗

kelset avatar Mar 21 '23 11:03 kelset

Fails
:no_entry_sign:

:clipboard: Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
:warning: :lock: package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by :no_entry_sign: dangerJS against 269336864a54ce89c5806dd64b74715b4c6b1689

github-actions[bot] avatar Mar 21 '23 11:03 github-actions[bot]

What's the actionable here, @robhogan @hoxyq? do we need to import and land this?

cipolleschi avatar Mar 27 '23 10:03 cipolleschi

@kelset Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?

hoxyq avatar May 17 '23 08:05 hoxyq

@kelset Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?

I'm at chainreact - will take a look next week 🤗

kelset avatar May 17 '23 12:05 kelset

@kelset Lorenzo Sciandra FTE Looks like we completely missed it, can you please resolve the conflicts and I will help with importing it this week?

I'm at chainreact - will take a look next week 🤗

Will take care of it, if you don't mind

hoxyq avatar May 17 '23 12:05 hoxyq

go for it 👍

kelset avatar May 17 '23 12:05 kelset

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 17 '23 14:05 facebook-github-bot

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 17 '23 14:05 facebook-github-bot

@hoxyq merged this pull request in facebook/react-native@f10dd3f6660bbe6347b65e871dd11a2290426abe.

facebook-github-bot avatar May 18 '23 21:05 facebook-github-bot